Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log error if invalid Bitmap passed to FlxG.addBitmap() #127

Merged

Conversation

IQAndreas
Copy link
Member

Resolves the following issue:

Resolves the following issue:
 * FlxG.as line 738,743 undefined property bitmapData
   - FlixelCommunity#15
   - AdamAtomic#217
moly added a commit that referenced this pull request Jan 11, 2013
Log error if invalid Bitmap passed to `FlxG.addBitmap()`
@moly moly merged commit 58f1e1f into FlixelCommunity:dev Jan 11, 2013
@jquave
Copy link

jquave commented Feb 15, 2013

I get an error from this commit:
/org/flixel/FlxG.as(754): col: 38 Error: Access of possibly undefined property ImgDefault through a reference with static type Class.

@IQAndreas
Copy link
Member Author

Ah, my bad. I see what happened. It's a quick fix, so I'll get it up this weekend.

Normally I make sure to "test compile" the code before commiting it, but I guess I forgot this time. Thanks for the catch, @jquave!

@jquave
Copy link

jquave commented Feb 15, 2013

I'm thinking we can just make ImgDefault public static, but not sure how that effects the existing use of ImgDefault. in FlxSprite.as.

@Dovyski
Copy link
Member

Dovyski commented Feb 15, 2013

I imagine the only reason why ImgDefault is not public is to avoid some sort of "class cluttering" for newcomers. I believe the change from private to public won't break anything and it's quite useful :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants