Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

current offset fixes #242

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

current offset fixes #242

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
25bfca4
current offset fixes
muskeinsingh Sep 5, 2018
5217202
Create .npmrc
muskeinsingh Sep 10, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 5 additions & 1 deletion src/core/RecyclerListView.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -300,7 +300,11 @@ export default class RecyclerListView<P extends RecyclerListViewProps, S extends

public getCurrentScrollOffset(): number {
const viewabilityTracker = this._virtualRenderer.getViewabilityTracker();
return viewabilityTracker ? viewabilityTracker.getLastActualOffset() + this.props.distanceFromWindow! : 0;
let currentOffset = (viewabilityTracker ? viewabilityTracker.getLastActualOffset() : 0);
if (currentOffset > this.props.distanceFromWindow) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While this will fix the specific issue internally, this doesn't look correct. An example would be having scrolled very little such that it is < distanceFromWindow. We will get 0 as the current offset which is incorrect because there indeed is a valid scroll offset

currentOffset += this.props.distanceFromWindow!;
}
return currentOffset;
}

public findApproxFirstVisibleIndex(): number {
Expand Down