Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

current offset fixes #242

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

current offset fixes #242

wants to merge 2 commits into from

Conversation

manishPatwari
Copy link
Collaborator

No description provided.

@@ -300,7 +300,11 @@ export default class RecyclerListView<P extends RecyclerListViewProps, S extends

public getCurrentScrollOffset(): number {
const viewabilityTracker = this._virtualRenderer.getViewabilityTracker();
return viewabilityTracker ? viewabilityTracker.getLastActualOffset() + this.props.distanceFromWindow! : 0;
let currentOffset = (viewabilityTracker ? viewabilityTracker.getLastActualOffset() : 0);
if (currentOffset > this.props.distanceFromWindow) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While this will fix the specific issue internally, this doesn't look correct. An example would be having scrolled very little such that it is < distanceFromWindow. We will get 0 as the current offset which is incorrect because there indeed is a valid scroll offset

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants