Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
398 Support optional "source" in /sensors/data [GET] #543
398 Support optional "source" in /sensors/data [GET] #543
Changes from all commits
83dfe54
ca7d9a9
d00be86
f4987db
764b7cf
d389c4a
aa2eb22
d89c22c
62488c3
eb8a951
12537d3
5cd066c
30f5dbb
d02dc94
eeb2e85
a5a150a
a050342
4759a0c
b1aae10
6b39307
2cebe89
92a2a47
da437ba
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe this could be in the non-fresh part of testing, as the test itself mutates no data. And you added the data points in both versions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I first implemented it in the non-fresh db test module, but it did interfere there. And I found it was tricky.
trickier than just adapting the assert statements that check the number of beliefs registered on the sensor shared by these tests.[That was actually only an issue in the fresh db test module]