398 Support optional "source" in /sensors/data [GET] #543
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: F.N. Claessen <felix@seita.nl>
Signed-off-by: F.N. Claessen <felix@seita.nl>
Signed-off-by: F.N. Claessen <felix@seita.nl>
Pull Request Test Coverage Report for Build 3600176789
💛 - Coveralls |
Signed-off-by: F.N. Claessen <felix@seita.nl>
Signed-off-by: F.N. Claessen <felix@seita.nl>
Signed-off-by: F.N. Claessen <felix@seita.nl>
Signed-off-by: F.N. Claessen <felix@seita.nl>
Signed-off-by: F.N. Claessen <felix@seita.nl>
Signed-off-by: F.N. Claessen <felix@seita.nl>
Signed-off-by: F.N. Claessen <felix@seita.nl>
Signed-off-by: F.N. Claessen <felix@seita.nl>
Signed-off-by: F.N. Claessen <felix@seita.nl>
Signed-off-by: F.N. Claessen <felix@seita.nl>
Signed-off-by: F.N. Claessen <felix@seita.nl>
Signed-off-by: F.N. Claessen <felix@seita.nl>
…rsion) Signed-off-by: F.N. Claessen <felix@seita.nl>
Signed-off-by: F.N. Claessen <felix@seita.nl>
Flix6x
added
bug
nhoening
approved these changes
Dec 1, 2022
There was a problem hiding this comment.
Great, also that you added a test for a crucial endpoint which wasn't covered before
One of my comments might make the test somewhat faster, I believe it should live in another module.
| @@ -50,3 +55,36 @@ def test_post_sensor_data( | |||
| assert len(beliefs) == expected_num_values | |||
| # check that values are scaled to the sensor unit correctly | |||
| assert pytest.approx(beliefs[0].event_value - expected_value) == 0 | |||
|
|
|||
|
|
|||
| def test_get_sensor_data( | |||
There was a problem hiding this comment.
I believe this could be in the non-fresh part of testing, as the test itself mutates no data. And you added the data points in both versions.
There was a problem hiding this comment.
I first implemented it in the non-fresh db test module, but it did interfere there. And I found it was tricky. trickier than just adapting the assert statements that check the number of beliefs registered on the sensor shared by these tests. [That was actually only an issue in the fresh db test module]
Signed-off-by: F.N. Claessen <felix@seita.nl>
Signed-off-by: F.N. Claessen <felix@seita.nl>
Signed-off-by: F.N. Claessen <felix@seita.nl>
Signed-off-by: F.N. Claessen <felix@seita.nl>
Signed-off-by: F.N. Claessen <felix@seita.nl>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow to filter requests for sensor data by data source. Users can find out relevant source ids from chart tooltips.
Also fixes the return message of
/sensors/data [GET]and the replacement of NaN values with null values in the returned JSON.