Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove bokeh dependency and obsolete UI views #476

Merged
merged 6 commits into from Aug 31, 2022
Merged

Remove bokeh dependency and obsolete UI views #476

merged 6 commits into from Aug 31, 2022

Conversation

Flix6x
Copy link
Contributor

@Flix6x Flix6x commented Aug 12, 2022

Closes #405.

There should be some follow-ups we could discuss, like increasing our test coverage, and deciding on what info tooltips on the dashboard map should contain (or just link directly to the asset page).

…tfolio pages

Signed-off-by: F.N. Claessen <felix@seita.nl>
Signed-off-by: F.N. Claessen <felix@seita.nl>
Signed-off-by: F.N. Claessen <felix@seita.nl>
@Flix6x Flix6x added this to In progress in Deprecate old database models via automation Aug 12, 2022
@coveralls
Copy link
Collaborator

coveralls commented Aug 12, 2022

Pull Request Test Coverage Report for Build 2962650355

  • 2 of 2 (100.0%) changed or added relevant lines in 2 files are covered.
  • 331 unchanged lines in 13 files lost coverage.
  • Overall coverage decreased (-2.6%) to 65.134%

Files with Coverage Reduction New Missed Lines %
flexmeasures/data/models/markets.py 1 70.4%
flexmeasures/data/models/time_series.py 1 71.16%
flexmeasures/ui/crud/assets.py 1 74.15%
flexmeasures/utils/geo_utils.py 1 62.0%
flexmeasures/data/models/assets.py 8 71.29%
flexmeasures/utils/coding_utils.py 8 36.36%
flexmeasures/data/queries/utils.py 10 51.32%
flexmeasures/data/services/time_series.py 14 22.95%
flexmeasures/utils/time_utils.py 18 62.83%
flexmeasures/data/queries/portfolio.py 37 0%
Totals Coverage Status
Change from base Build 2947332461: -2.6%
Covered Lines: 6475
Relevant Lines: 9336

💛 - Coveralls

@Flix6x Flix6x marked this pull request as ready for review August 12, 2022 22:51
@Flix6x Flix6x self-assigned this Aug 12, 2022
@Flix6x Flix6x requested a review from nhoening August 12, 2022 22:55
Copy link
Contributor

@nhoening nhoening left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good start of removing things, we need to tackle this in more steps anyways, starting with the legacy data models.

I discovered that Coveralls is not showing you the source with changes (newly uncovered lines), unless you log in there (using your Github credentials).
Then, pages like https://coveralls.io/builds/51635571 become very useful to understand which parts of the code base are now uncovered.

@@ -138,37 +126,16 @@
.bindPopup(`
<div class="leaflet-marker-popup">
<div class="row">
<div class="col-sm-12">
<div class="col-sm-9">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As it sits now, the space isn't being used. The title uses 9 cols, and the button below uses 3.
It leads to a lot of empty space on the right side.

Was that the intention?

And what would it take to display the current state in text form, as we discussed, e.g. "Current state: X% (of ".

Of course, the latter could also be done in a new ticket. But if it's small, this can be a good place as we are now taking that feature away. I might volunteer.

Deprecate old database models automation moved this from In progress to Review in progress Aug 21, 2022
@Flix6x Flix6x modified the milestone: 0.11.1 Aug 29, 2022
Signed-off-by: Nicolas Höning <nicolas@seita.nl>
@nhoening nhoening added this to the 0.12.0 milestone Aug 30, 2022
Deprecate old database models automation moved this from Review in progress to Reviewer approved Aug 30, 2022
@nhoening
Copy link
Contributor

nhoening commented Aug 30, 2022

@Flix6x mentioned there is still documentation in place mentioning plots which need Bokeh support (latest state?). That should be removed.

This ticket talks about removing tutorials needing Bokeh (this is about charts) and potentially moving to Altair for this useful feature.

This is the tutorial in question.

  1. I propose we can leave the tutorial update to issue update chart plotting tutorial w.r.t. plotting #388, so this once can move on, helping us to also move on with dependency upgrades.
  2. @Flix6x - can we keep supporting such a custom charting feature? I believe it would look more like an asset page (multiple plots of single sensor data), but plotted in a custom front-end.

@Flix6x
Copy link
Contributor Author

Flix6x commented Aug 30, 2022

can we keep supporting such a custom charting feature?

For sure. We already fetch charts using dedicated API endpoints, so it should just be a matter of moving them from the dev API blueprint to the v3_0 API blueprint, and adjusting the documentation.

I believe it would look more like an asset page (multiple plots of single sensor data), but plotted in a custom front-end.

They would look different (better imo) indeed. I believe the endpoint for fetching a sensor chart would be a closer replacement of the endpoint for fetching a "latest power state" chart than the endpoint for fetching an asset chart.

I think this PR should still get a changelog entry, and then it should be ready to be merged.

Signed-off-by: Nicolas Höning <nicolas@seita.nl>
@nhoening nhoening merged commit f024c29 into main Aug 31, 2022
Deprecate old database models automation moved this from Reviewer approved to Done Aug 31, 2022
@nhoening nhoening deleted the bye_bye_bokeh branch August 31, 2022 09:24
@nhoening nhoening mentioned this pull request Sep 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Bokeh -> Altair
3 participants