Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove latest state plot from asset page #493

Merged

Conversation

Flix6x
Copy link
Contributor

@Flix6x Flix6x commented Aug 29, 2022

Closes #492.

Signed-off-by: F.N. Claessen <felix@seita.nl>
@Flix6x Flix6x added this to the 0.11.1 milestone Aug 29, 2022
@Flix6x Flix6x self-assigned this Aug 29, 2022
@coveralls
Copy link
Collaborator

coveralls commented Aug 29, 2022

Pull Request Test Coverage Report for Build 2952009278

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 33 unchanged lines in 4 files lost coverage.
  • Overall coverage decreased (-0.3%) to 67.438%

Files with Coverage Reduction New Missed Lines %
flexmeasures/data/models/time_series.py 1 71.16%
flexmeasures/ui/crud/assets.py 1 74.15%
flexmeasures/data/services/time_series.py 3 33.88%
flexmeasures/ui/charts/latest_state.py 28 18.97%
Totals Coverage Status
Change from base Build 2947332461: -0.3%
Covered Lines: 7230
Relevant Lines: 10151

💛 - Coveralls

Signed-off-by: F.N. Claessen <felix@seita.nl>
@Flix6x Flix6x marked this pull request as ready for review August 29, 2022 21:52
@Flix6x Flix6x requested a review from nhoening August 29, 2022 21:52
@Flix6x
Copy link
Contributor Author

Flix6x commented Aug 31, 2022

Not that this PR, a fix for the 0.11.x series, implements some of the same line removals as #476 (which also removes other bokeh related lines, and is by now already merged with main). I would still like to merge this PR, so I can then backport it.

@Flix6x Flix6x merged commit 3c3af69 into main Sep 5, 2022
@Flix6x Flix6x deleted the Issue-492_Asset_page_shows_error_due_to_loading_obsolete_plot branch September 5, 2022 09:50
Flix6x added a commit that referenced this pull request Sep 5, 2022
Stop letting the server create an obsolete bokeh plot of the latest state on the asset page.

* Remove latest state plot from asset page

Signed-off-by: F.N. Claessen <felix@seita.nl>

* Changelog entry

Signed-off-by: F.N. Claessen <felix@seita.nl>

Signed-off-by: F.N. Claessen <felix@seita.nl>
@Flix6x Flix6x added bug Something isn't working and removed Still Needs Manual Backport labels Sep 5, 2022
Flix6x added a commit that referenced this pull request Sep 5, 2022
Signed-off-by: F.N. Claessen <felix@seita.nl>
Flix6x added a commit that referenced this pull request Sep 5, 2022
Do not fail asset page if one of the shown sensors records instantaneous values.


* Do not resample data of sensors recording instantaneous values

Signed-off-by: F.N. Claessen <felix@seita.nl>

* Use linear interpolation for instantaneous sensors

Signed-off-by: F.N. Claessen <felix@seita.nl>

* Changelog entry

Signed-off-by: F.N. Claessen <felix@seita.nl>

* Fix tooltip

Signed-off-by: F.N. Claessen <felix@seita.nl>

* Fix case with only instantaneous sensors

Signed-off-by: F.N. Claessen <felix@seita.nl>

* Fix changelog entry for PR #493 / Issue #492

Signed-off-by: F.N. Claessen <felix@seita.nl>

* Fix changelog date format

Signed-off-by: F.N. Claessen <felix@seita.nl>

* Add release date for 0.11.1

Signed-off-by: F.N. Claessen <felix@seita.nl>

Signed-off-by: F.N. Claessen <felix@seita.nl>
Flix6x added a commit that referenced this pull request Sep 5, 2022
…eous values (#491)

Do not fail asset page if one of the shown sensors records instantaneous values.

* Do not resample data of sensors recording instantaneous values

Signed-off-by: F.N. Claessen <felix@seita.nl>

* Use linear interpolation for instantaneous sensors

Signed-off-by: F.N. Claessen <felix@seita.nl>

* Changelog entry

Signed-off-by: F.N. Claessen <felix@seita.nl>

* Fix tooltip

Signed-off-by: F.N. Claessen <felix@seita.nl>

* Fix case with only instantaneous sensors

Signed-off-by: F.N. Claessen <felix@seita.nl>

* Fix changelog entry for PR #493 / Issue #492

Signed-off-by: F.N. Claessen <felix@seita.nl>

* Fix changelog date format

Signed-off-by: F.N. Claessen <felix@seita.nl>

* Add release date for 0.11.1

Signed-off-by: F.N. Claessen <felix@seita.nl>

Signed-off-by: F.N. Claessen <felix@seita.nl>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Asset page shows error due to loading obsolete plot
3 participants