Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SQLServer - Fix Always-On metrics query for replica_failover_mode and replica_failover_readiness #17503

Merged
merged 3 commits into from
May 2, 2024

Conversation

joelmarcotte
Copy link
Contributor

What does this PR do?

User contribution from #17439. Created on repo to add a changelog. Original contribution from @omarmxdbe

  • Fixes the always-on query in SQLServer to prevent duplicate rows. This affects the following 2 metrics sqlserver.ao.replica_failover_mode and sqlserver.ao.replica_failover_readiness.

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Changelog entries must be created for modifications to shipped code
  • Add the qa/skip-qa label if the PR doesn't need to be tested during QA.
  • If you need to backport this PR to another branch, you can add the backport/<branch-name> label to the PR and it will automatically open a backport PR once this one is merged

@joelmarcotte joelmarcotte requested review from a team as code owners May 2, 2024 13:45
@joelmarcotte joelmarcotte changed the title Fix Always-On metrics query for replica_failover_mode and replica_failover_readiness SQLServer - Fix Always-On metrics query for replica_failover_mode and replica_failover_readiness May 2, 2024
@lu-zhengda lu-zhengda added the qa/skip-qa Automatically skip this PR for the next QA label May 2, 2024
lu-zhengda
lu-zhengda previously approved these changes May 2, 2024
nenadnoveljic
nenadnoveljic previously approved these changes May 2, 2024
@@ -0,0 +1 @@
Fix Always-On metrics query for replica_failover_mode and replica_failover_readiness
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you provide more detail about what the fix is doing?

@joelmarcotte joelmarcotte dismissed stale reviews from nenadnoveljic and lu-zhengda via 7047df6 May 2, 2024 14:37
@joelmarcotte joelmarcotte merged commit 238d867 into master May 2, 2024
36 checks passed
@joelmarcotte joelmarcotte deleted the joel.marcotte/omarmxdbe-contribution-ao-fix branch May 2, 2024 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants