Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Commit to eliminate duplicate rows from availability_replicas_metrics #17439

Closed
wants to merge 1 commit into from

Conversation

omarmxdbe
Copy link

What does this PR do?

Fix availability_replicas_metrics from SqlAvailabilityReplicas class eliminating duplicates between sys.dm_hadr_database_replica_cluster_states and sys.dm_hadr_database_replica_states by adding join predicate based on group_database_id

Motivation

Reduce network waits reported by DataDog DBM

Additional Notes

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Changelog entries must be created for modifications to shipped code
  • Add the qa/skip-qa label if the PR doesn't need to be tested during QA.
  • If you need to backport this PR to another branch, you can add the backport/<branch-name> label to the PR and it will automatically open a backport PR once this one is merged

@joelmarcotte
Copy link
Contributor

Thank you for your contribution, I tried pushing a changelog but for some reason github didn't let me. I recreated in a new on-repo PR here #17503

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants