Merge pull request #103 from pdsmcgavin/select-last-with-arguments

[select-last-with-arguments]
DamirSvrtan · Nov 20, 2023 · 58c309b · 58c309b
2 parents 9ebf505 + 6760318
commit 58c309b
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 0 deletions.
diff --git a/lib/fasterer/scanners/method_call_scanner.rb b/lib/fasterer/scanners/method_call_scanner.rb
@@ -157,6 +157,8 @@ def check_last_offense
 
       case method_call.receiver.name
       when :select
+        return if method_call.arguments.count > 0
+
         add_offense(:select_last_vs_reverse_detect)
       end
     end

diff --git a/spec/support/analyzer/25_select_last_vs_reverse_detect.rb b/spec/support/analyzer/25_select_last_vs_reverse_detect.rb
@@ -5,3 +5,5 @@ def slow
 def fast
   ARRAY.reverse.detect { |x| (x % 10).zero? }
 end
+
+ARRAY.select { |x| (x % 10).zero? }.last(5)