[select-last-with-arguments]

Don't add offense if .last is called with arguments in the same vein as .first change for 0.10.1
DamirSvrtan · Sep 25, 2023 · 6760318 · 6760318
1 parent e6e2f62
commit 6760318
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 0 deletions.
diff --git a/lib/fasterer/scanners/method_call_scanner.rb b/lib/fasterer/scanners/method_call_scanner.rb
@@ -155,6 +155,8 @@ def check_last_offense
 
       case method_call.receiver.name
       when :select
+        return if method_call.arguments.count > 0
+
         add_offense(:select_last_vs_reverse_detect)
       end
     end

diff --git a/spec/support/analyzer/25_select_last_vs_reverse_detect.rb b/spec/support/analyzer/25_select_last_vs_reverse_detect.rb
@@ -5,3 +5,5 @@ def slow
 def fast
   ARRAY.reverse.detect { |x| (x % 10).zero? }
 end
+
+ARRAY.select { |x| (x % 10).zero? }.last(5)