Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Requester validation of LargeResponse #1207

Open
steven-bellock opened this issue Sep 13, 2022 · 2 comments · May be fixed by #2252
Open

Requester validation of LargeResponse #1207

steven-bellock opened this issue Sep 13, 2022 · 2 comments · May be fixed by #2252
Assignees

Comments

@steven-bellock
Copy link
Contributor

steven-bellock commented Sep 13, 2022

Currently the Requester checks if the Responder is chunking responses that it shouldn't be, like VERSION, after it has already received the chunked response at the end of libspdm_receive_spdm_response. Instead the check should occur immediately after the LargeResponse error from the Responder and be based on the request message. So if the Requester sends GET_VERSION and the Responder replies with LargeResponse then the Requester should immediately error out, rather than receiving the chunked VERSION response and then erroring out.

@steven-bellock
Copy link
Contributor Author

In addition the list of requests that should not result in a LargeResponse error should be expanded.

@jyao1
Copy link
Member

jyao1 commented Sep 19, 2022

9/19/2022 - steven will propose a fix.

@steven-bellock steven-bellock added this to the Q1 2023 milestone Dec 1, 2022
@steven-bellock steven-bellock removed this from the Q1 2023 milestone May 29, 2023
steven-bellock added a commit to steven-bellock/libspdm that referenced this issue Jul 18, 2023
Fix DMTF#1207.

Signed-off-by: Steven Bellock <sbellock@nvidia.com>
@steven-bellock steven-bellock linked a pull request Jul 18, 2023 that will close this issue
steven-bellock added a commit to steven-bellock/libspdm that referenced this issue Jul 18, 2023
Fix DMTF#1207.

Signed-off-by: Steven Bellock <sbellock@nvidia.com>
steven-bellock added a commit to steven-bellock/libspdm that referenced this issue Jul 18, 2023
Fix DMTF#1207.

Signed-off-by: Steven Bellock <sbellock@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants