An ERROR message with an ErrorCode == LargeResponse shall not be allowed in ResponseToLargeRequest.

[Zhiqiang520]

An ERROR message with an ErrorCode == LargeResponse shall not be allowed in ResponseToLargeRequest.

1. Refer to paragraph 696 in DSP0274_1.2.1.

An ERROR message with an ErrorCode == LargeResponse shall not be allowed in ResponseToLargeRequest.

2. I have submitted one pull request to add unit test for An ERROR message with an ErrorCode == LargeResponse shall not be allowed in ResponseToLargeRequest.

3. Test result is fail: Put an ERROR message with an ErrorCode == LargeResponse in ResponseToLargeRequest, currently the requester take this LargeResponse ERROR message as a valid message and then send CHUNK_GET request message.
   I think it is not a right behavior, the requester should take it as a invalid message.

[steven-bellock]

This is somewhat related to #1207.

[Zhiqiang520]

I think maybe we can add the check whether ErrorCode == LargeResponse is in ResponseToLargeRequest field, before libspdm_copy_mem at the following line 489 and 517.

libspdm/library/spdm_requester_lib/libspdm_req_send_receive.c

Lines 483 to 500 in 675ba03

	if (spdm_response->header.param1
	& SPDM_CHUNK_SEND_ACK_RESPONSE_ATTRIBUTE_EARLY_ERROR_DETECTED) {
	/* Store the error response in scratch buffer to be read by
	* libspdm_receive_spdm_response and returned to its caller
	* and handled in the error response handling flow */
	libspdm_copy_mem(
	send_info->large_message,
	send_info->large_message_capacity,
	(uint8_t*) (spdm_response + 1),
	response_size - sizeof(spdm_chunk_send_ack_response_t));
	send_info->large_message_size =
	(response_size - sizeof(spdm_chunk_send_ack_response_t));
	status = LIBSPDM_STATUS_SUCCESS;
	break;
	}

libspdm/library/spdm_requester_lib/libspdm_req_send_receive.c

Lines 513 to 523 in 675ba03

	if (send_info->chunk_bytes_transferred >= send_info->large_message_size) {
	/* All bytes have been transferred. Store response in scratch buffer
	* to be read by libspdm_receive_spdm_response */
	libspdm_copy_mem(
	send_info->large_message, send_info->large_message_capacity,
	chunk_ptr, response_size - sizeof(spdm_chunk_send_ack_response_t));
	send_info->large_message_size =
	(response_size - sizeof(spdm_chunk_send_ack_response_t));
	break;
	}