Validate chunking support in libspdm in session. #1206
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jyao1
reviewed
Sep 13, 2022
jyao1
reviewed
Sep 13, 2022
qizhangz
force-pushed
the
chunk_fix2
branch
from
62e040e
to
1efba79
Compare
jyao1
approved these changes
Sep 13, 2022
steven-bellock
requested changes
Sep 13, 2022
|
The spot in the code where the Response is checked to see if it can be chunked or not is wrong. I'll file a separate issue. |
Signed-off-by: Qi Zhang <qi1.zhang@intel.com>
Signed-off-by: Qi Zhang <qi1.zhang@intel.com>
Signed-off-by: Qi Zhang <qi1.zhang@intel.com>
qizhangz
force-pushed
the
chunk_fix2
branch
from
1efba79
to
24f411f
Compare
|
@steven-bellock , I merge it since we need the patch to test chunking. Feel free to file new one, if you think any improvement is needed. |
|
Ok I expanded #1207 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix: #1203