Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

catcma (GECCO2024) #178

Merged
merged 4 commits into from
May 21, 2024
Merged

catcma (GECCO2024) #178

merged 4 commits into from
May 21, 2024

Conversation

ha-mano
Copy link
Collaborator

@ha-mano ha-mano commented May 15, 2024

I have implemented CatCMA [Hamano+, GECCO2024].

@nomuramasahir0 nomuramasahir0 self-requested a review May 15, 2024 12:06
_SIGMA_MAX = 1e32


class CatCMA:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added the link for the paper (arXiv).

cmaes/_catcma.py Outdated
min_eigenvalue:
Lower bound of eigenvalue of multivariate Gaussian distribution (optional).

delta_init:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure whether there is a situation such that we want to tune this.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The variables delta_init and Delta_max have been removed from the __init__ method.

cmaes/_catcma.py Outdated
delta_init:
Initial trust region radius in ASNG (optional).

Delta_max:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The variables delta_init and Delta_max have been removed from the __init__ method (as mentioned above).

seed: Optional[int] = None,
population_size: Optional[int] = None,
cov: Optional[np.ndarray] = None,
cat_param: Optional[np.ndarray] = None,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add the validation.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added the validation for self._n_ca and cat_param.

@nomuramasahir0
Copy link
Collaborator

Thanks! LGTM.

@nomuramasahir0 nomuramasahir0 merged commit 719fa3b into CyberAgentAILab:main May 21, 2024
13 checks passed
@ha-mano ha-mano mentioned this pull request May 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants