Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dark overlay #2531

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

dark overlay #2531

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
7b5f645
use dark overlay
BandanaKM Aug 29, 2022
6a9da57
feat(Footer): remove shop link from footer
borisonr Aug 29, 2022
7a656d1
chore(release): publish
codecademy-gh-api Aug 29, 2022
d2c0d3c
Merge branch 'main' of github.com:Codecademy/gamut into bm-dark-modal…
BandanaKM Aug 29, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 5 additions & 1 deletion packages/gamut/src/Modals/types.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,11 @@ import { ModalContainer } from './elements';
export interface ModalOverlayProps
extends Pick<
OverlayProps,
'isOpen' | 'onRequestClose' | 'clickOutsideCloses' | 'escapeCloses'
| 'isOpen'
| 'onRequestClose'
| 'clickOutsideCloses'
| 'escapeCloses'
| 'shroud'
> {}

export interface ModalBaseProps
Expand Down
4 changes: 2 additions & 2 deletions packages/gamut/src/Overlay/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ export type OverlayProps = {
isOpen?: boolean;
/** Whether the overlay renders inline to its container or creates a portal to the end of the body */
inline?: boolean;
/** Whether the overlay has a transparent or a shrouded opaque background */
/** Whether the overlay has a transparent or a shrouded background with slight opacity */
shroud?: boolean;
/** Whether the overlay allows scroll */
allowScroll?: boolean;
Expand All @@ -37,7 +37,7 @@ export type OverlayProps = {
const OverlayContainer = styled(FlexBox)(
states({
shroud: {
bg: 'shadow-opaque',
bg: 'shadow-black-heavy',
},
inline: {
position: 'absolute',
Expand Down