Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dark overlay #2531

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

dark overlay #2531

wants to merge 4 commits into from

Conversation

BandanaKM
Copy link
Contributor

Overview

Screen Shot 2022-08-10 at 1 31 50 PM

This change:

  • Modifies the Overlay's shroud prop to have color shadow-black-heavy as specified in the mocks (shown in the pic above)
  • Stephen mentioned that we want all overlays to have this opacity

PR Checklist

Testing Instructions

Don't make me tap the sign.

PR Links and Envs

Repository PR Link PR Env
Monolith Monolith PR Monolith Env
Portal Portal Link Portal Env
Another Repo Another Link Another Env

@BandanaKM BandanaKM requested a review from a team as a code owner August 29, 2022 18:53
@nx-cloud
Copy link

nx-cloud bot commented Aug 29, 2022

☁️ Nx Cloud Report

CI is running/has finished running commands for commit d2c0d3c. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 4 targets

Sent with 💌 from NxCloud.

@BandanaKM BandanaKM changed the title use dark overlay dark overlay Aug 29, 2022
borisonr and others added 3 commits August 29, 2022 14:54
Remove link to shop from footer
 - @codecademy/gamut-kit@0.6.192
 - @codecademy/gamut-labs@33.2.0
 - @codecademy/styleguide@61.4.0
@codecademydev
Copy link
Collaborator

📬Published Alpha Packages:

@codecademy/gamut-kit@0.6.193-alpha.d2c0d3.0
@codecademy/gamut-labs@33.3.0-alpha.d2c0d3.0
@codecademy/gamut@50.5.5-alpha.d2c0d3.0
@codecademy/monaco@0.6.82-alpha.d2c0d3.0
@codecademy/styleguide@61.5.0-alpha.d2c0d3.0

@codecademydev
Copy link
Collaborator

🚀 Styleguide deploy preview ready!

https://630d1f675a0cc61c12c28bc3--gamut-preview.netlify.app

Deploy Logs

Copy link
Contributor

@dreamwasp dreamwasp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
6 participants