Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setup pesayetu in monorepo #483

Merged
merged 34 commits into from
Aug 7, 2023
Merged

Setup pesayetu in monorepo #483

merged 34 commits into from
Aug 7, 2023

Conversation

kelvinkipruto
Copy link
Contributor

@kelvinkipruto kelvinkipruto commented Jul 11, 2023

Description

This PR experiments with moving PesaYetu into this integrated monorepo

Fixes # (issue)

Type of change

  • New feature (non-breaking change which adds functionality)

Screenshots

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation

@vercel
Copy link

vercel bot commented Jul 11, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
codeforafrica ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 28, 2023 2:04pm

Signed-off-by: Kipruto <43873157+kelvinkipruto@users.noreply.github.com>
Signed-off-by: Kipruto <43873157+kelvinkipruto@users.noreply.github.com>
This reverts commit 7fb33fb.
Signed-off-by: Kipruto <43873157+kelvinkipruto@users.noreply.github.com>
Copy link
Member

@kilemensi kilemensi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏽


This PR is too huge for me to test on my current connection.

apps/pesayetu/.eslintrc.js Outdated Show resolved Hide resolved
@kelvinkipruto
Copy link
Contributor Author

@kilemensi This looks ok, but there is one issue, our custom theme is not being applied, and it instead uses the default theme. It works well on the original Pesayetu.

@kilemensi
Copy link
Member

@kilemensi This looks ok, but there is one issue, our ...

Have you reviewed and made sure the theme here is created and applied the say way as say in @/charterafrica app @kelvinkipruto ?

@kelvinkipruto
Copy link
Contributor Author

@kilemensi Yes. The creation of the themes looks similar. I think the only difference is that in charterafrica, it is handled from the new @commons-ui/core in the monorepo. For Pesayetu we're still using the older @commons-ui/core.

@kilemensi
Copy link
Member

@kilemensi Yes. The creation of the themes looks similar...

So how do the two @commons-ui/core packages co-exists @kelvinkipruto ?

@kilemensi
Copy link
Member

... and do we need to use the old @commons-ui/core if we've already upgraded it to the latest MUI?

@kelvinkipruto
Copy link
Contributor Author

So how do the two @commons-ui/core packages co-exists

For pesayetu we're getting it from npm.

@kelvinkipruto
Copy link
Contributor Author

and do we need to use the old @commons-ui/core if we've already upgraded it to the latest MUI?

Yes @kilemensi There are some components in the old one that are required and are not in the new one.

@kelvinkipruto
Copy link
Contributor Author

There are some components in the old one that are required and are not in the new one.

They are not that many of them. I guess we can recreate them as components to get rid of the older @commons-ui

@kilemensi
Copy link
Member

If it works on the old repo but not here @kelvinkipruto then my first assumption would be the two @commnos-ui/core. If we can get rid of the old one that would be the way to go.

My advice: test it

  1. Remove the old @commons-ui/core and point everything to the new @common-ui/core.
  2. Some components will fail but try disabling them and see if the rest works correctly e.g. the theme is applied correctly.
  3. If point 2 above is true, then create issues to track those failing component that you can update on separate PR(s).
  4. If point 2 above is not true, then we dig further to figure out what is going on.

@kilemensi
Copy link
Member

... and @kelvinkipruto ?

@kelvinkipruto
Copy link
Contributor Author

@kilemensi The issue is not with @commons-ui. Removing references to the ones does not apply the theme.

Signed-off-by: Kipruto <43873157+kelvinkipruto@users.noreply.github.com>
@kelvinkipruto
Copy link
Contributor Author

kelvinkipruto commented Aug 7, 2023

Further changes i.e migration to emotion (#548) to be handled in a new PR

@kelvinkipruto kelvinkipruto added this pull request to the merge queue Aug 7, 2023
Merged via the queue into main with commit 95f04df Aug 7, 2023
2 checks passed
@kelvinkipruto kelvinkipruto deleted the ft/pesayetu-setup branch August 7, 2023 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants