-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Setup pesayetu in monorepo #483
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Signed-off-by: Kipruto <43873157+kelvinkipruto@users.noreply.github.com>
Signed-off-by: Kipruto <43873157+kelvinkipruto@users.noreply.github.com>
This reverts commit 7fb33fb.
Signed-off-by: Kipruto <43873157+kelvinkipruto@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍🏽
This PR is too huge for me to test on my current connection.
@kilemensi This looks ok, but there is one issue, our custom theme is not being applied, and it instead uses the default theme. It works well on the original Pesayetu. |
Have you reviewed and made sure the theme here is created and applied the say way as say in @/charterafrica app @kelvinkipruto ? |
@kilemensi Yes. The creation of the themes looks similar. I think the only difference is that in |
So how do the two @commons-ui/core packages co-exists @kelvinkipruto ? |
... and do we need to use the old |
For pesayetu we're getting it from npm. |
Yes @kilemensi There are some components in the old one that are required and are not in the new one. |
They are not that many of them. I guess we can recreate them as components to get rid of the older |
If it works on the old repo but not here @kelvinkipruto then my first assumption would be the two My advice: test it
|
... and @kelvinkipruto ? |
@kilemensi The issue is not with |
Signed-off-by: Kipruto <43873157+kelvinkipruto@users.noreply.github.com>
Further changes i.e migration to emotion (#548) to be handled in a new PR |
Description
This PR experiments with moving PesaYetu into this integrated monorepo
Fixes # (issue)
Type of change
Screenshots
Checklist: