-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to MUI 5 #215
Upgrade to MUI 5 #215
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Signed-off-by: Kipruto <43873157+kelvinkipruto@users.noreply.github.com>
Finally got this to work as expected.
|
@kilemensi @thepsalmist @koechkevin Please see the above steps I took to get Pesayetu working with the latest MUI Version. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kelvinkipruto It is really awesome to get this working. Couldn't be best if the steps were added as a build script?. Just thinking. What do you think @kilemensi
Good stuff @kelvinkipruto .
Lets review and confirm that if there are any issues, they're on PesaYetu side and not |
Looks like you don't have the necessary background of why we're doing this @koechkevin. Sorry for that.
|
This is still failing Vercel deployment @kelvinkipruto |
Any updates or blockers @kelvinkipruto ? |
@kilemensi This is now ready for re-review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Why is this merged @kelvinkipruto? From PR description: |
@kilemensi I think I forgot to update that part of the description. Initially, it was to test out commons-ui, and it also involved updating MUI. We resolved the commons-ui issue and continued the MUI upgrade here. I have reverted it in #228. |
Description
This PR upgrades MUI to the latest version
Fixes # (issue)
This PR will be closed, and not merged when the issue is resolved
Please delete options that are not relevant.
Screenshots
Checklist: