Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to MUI 5 #215

Merged
merged 29 commits into from
Jul 20, 2023
Merged

Upgrade to MUI 5 #215

merged 29 commits into from
Jul 20, 2023

Conversation

kelvinkipruto
Copy link
Contributor

@kelvinkipruto kelvinkipruto commented Oct 19, 2022

Description

This PR upgrades MUI to the latest version

Fixes # (issue)

This PR will be closed, and not merged when the issue is resolved

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

Screenshots

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation

@vercel
Copy link

vercel bot commented Oct 19, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
pesayetu ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 19, 2023 10:36am

Signed-off-by: Kipruto <43873157+kelvinkipruto@users.noreply.github.com>
@kelvinkipruto
Copy link
Contributor Author

Finally got this to work as expected.
Steps to check:

Ensure you are using yarn classic. yarn set version classic

  1. First use the updated @commons-ui. It is in this PR
  2. Build commons-ui then copy packages/core/package.json to packages/core/build/package.json
  3. CD to packages/core/build and run yarn link to create a local package
  4. In Pesayetu, checkout this PR
  5. Add the local dependency added in step 3 by running yarn link "@commons-ui/core"
  6. Run Pesayetu and check if it is working.

@kelvinkipruto
Copy link
Contributor Author

@kilemensi @thepsalmist @koechkevin Please see the above steps I took to get Pesayetu working with the latest MUI Version.

Copy link

@koechkevin koechkevin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kelvinkipruto It is really awesome to get this working. Couldn't be best if the steps were added as a build script?. Just thinking. What do you think @kilemensi

@kilemensi
Copy link
Member

Good stuff @kelvinkipruto .

  1. There is a bit of visual difference e.g. navigation, and
  2. There are error messages (check console) e.g. Hidden component has been deprecated in v5.

S

Lets review and confirm that if there are any issues, they're on PesaYetu side and not @commons-ui. Once we're there, we can cut a new version of @commons-ui and publish to npm. That should speed up fixes on PesaYetu side.

@kilemensi
Copy link
Member

@kelvinkipruto It is really awesome ...

Looks like you don't have the necessary background of why we're doing this @koechkevin. Sorry for that.

  1. All future front-end development will be happening in https://github.com/CodeForAfrica/ui (Nextjs 13, MUI v5, etc.).
  2. All this is the necessary but once-off work to get this repo to be MUI v5 compatible so that we can migrate the code into the above monorepo.

@kilemensi
Copy link
Member

This is still failing Vercel deployment @kelvinkipruto

@kilemensi kilemensi removed the request for review from esirK July 10, 2023 09:56
@kilemensi
Copy link
Member

Any updates or blockers @kelvinkipruto ?

@kelvinkipruto kelvinkipruto changed the title Ft/check commons UI Upgrade to MUI 5 Jul 19, 2023
@kelvinkipruto
Copy link
Contributor Author

@kilemensi This is now ready for re-review.

Copy link
Member

@kilemensi kilemensi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kelvinkipruto kelvinkipruto merged commit 6a30100 into main Jul 20, 2023
2 checks passed
@kelvinkipruto kelvinkipruto deleted the ft/check-commons-ui branch July 20, 2023 06:18
@kilemensi
Copy link
Member

Why is this merged @kelvinkipruto?

From PR description:
This PR will be closed, and not merged when the issue is resolved

@kelvinkipruto
Copy link
Contributor Author

@kilemensi I think I forgot to update that part of the description. Initially, it was to test out commons-ui, and it also involved updating MUI. We resolved the commons-ui issue and continued the MUI upgrade here. I have reverted it in #228.

@kelvinkipruto kelvinkipruto restored the ft/check-commons-ui branch July 20, 2023 06:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants