Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NextJS 13 upgrade #229

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

NextJS 13 upgrade #229

wants to merge 5 commits into from

Conversation

kelvinkipruto
Copy link
Contributor

Description

This PR updates the project to use NextJS 13.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation

@vercel
Copy link

vercel bot commented Jul 20, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
pesayetu ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 21, 2023 9:13am

Copy link
Member

@kilemensi kilemensi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM


I'm assuming we're not merging this one also.

@@ -18,17 +18,23 @@ const Connector = () => {
?.getBoundingClientRect();

if (firstElement && secondElement) {
// eslint-disable-next-line no-unsafe-optional-chaining
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No easy way to fix these? Lots of disabling.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let me look at fixing it.

src/functions/menus/getNavigationMenu.js Outdated Show resolved Hide resolved
Co-authored-by: Clemence Kyara <kilemensi@users.noreply.github.com>
@kelvinkipruto
Copy link
Contributor Author

I'm assuming we're not merging this one also.

Yes. We will close it if it is ok.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants