Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the same vanilla terminology for biome blend option in config screen #2267

Open
wants to merge 3 commits into
base: dev
Choose a base branch
from

Conversation

MeeniMc
Copy link
Contributor

@MeeniMc MeeniMc commented Jan 19, 2024

Use the same vanilla terminology for biome blend option in config screen
(e.g., 5x5 is a radius of 2)

@MeeniMc MeeniMc force-pushed the config/blendradius branch 2 times, most recently from e87c12c to bdb3a7f Compare January 19, 2024 05:06
(e.g., 5x5 is a radius of 2)
1x1 still shows as 1x1 because Sodium always blend.

Signed-off-by: MeeniMc <68366846+MeeniMc@users.noreply.github.com>
Value of 0 can be set by vanilla, and work as intended, simply using
only smooth biome transitions without blending.

Signed-off-by: MeeniMc <68366846+MeeniMc@users.noreply.github.com>
@MeeniMc
Copy link
Contributor Author

MeeniMc commented Feb 26, 2024

Updated according to discord discussion. "[...] but it should just be implemented using a custom formatter (manipulating the actual config value like that is problematic)".

2 notes:

  1. When using the shift-p vanilla screen, it would be possible to set blending radius to 0. The resulting Sodium configuration works. Solution: I let the Sodium slider take the 0 input, and clarified in the tooltip that this case is not blended, but still smoothed.
  2. It was not clear to me what was 'problematic' with the prior approach. The value in the config file, and in the rest of the codebase would still be expressed in radius (unchanged from prior versions of Sodium, that is, 2 for the 5x5 case). I did the requested changes anyway, thus when holding the slider widget, it will now show the radius value, but we still clarify how e.g., 2 is equivalent to 5x5 Vanilla nomenclature when the widget is not held.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants