Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ja_jp.json #5851

Open
wants to merge 1 commit into
base: 1.20.1
Choose a base branch
from
Open

Update ja_jp.json #5851

wants to merge 1 commit into from

Conversation

TwelveYO21
Copy link

Sorted as well as the line in en_us.json

Sorted as well as the line in en_us.json
@karakufire
Copy link
Contributor

karakufire commented Feb 14, 2024

Your this pull-request looks me draft or work in progress.
I'll evaluate higher the parts that tries to fix the differences between the 1.19.2 and 1.20.1 than other changes.
But, I couldn't find the meanings following changes:

  • Sorted as well as the line in en_us.json

    • I think there is no need to bother changing entries order.
  • Almost your addtions is taken by untranslated strings.
  • Lines at 175-184, what is the meanings of re-adding entries that remain English?
  • Lines at 774-783, they are REAL used. Read the manual and check shader list page.

Finally, if this pull-request is a work in progress, it should be draft. And if you pull-requested this as completed, there is no point in merging this request.

@TwelveYO21
Copy link
Author

Sorry for the late reply.
I just adapted it to en_us.json in 1.20.1. I can't help with the translation work, but I just made it easier to edit later.

@karakufire
Copy link
Contributor

At least the removes Lines at 774-783, desc.immersiveengineering.info.shader.reference.*, are not acceptable. Because they are still used in manual.
If you still would like ImmersiveEngineering to merge this pull-request, you should revert this changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants