-
Notifications
You must be signed in to change notification settings - Fork 128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable or Disable Multiple Create operation based on feature flag value #2116
Enable or Disable Multiple Create operation based on feature flag value #2116
Conversation
…hether entity is linking or not
…le-create-feature-flag
/azp run |
Azure Pipelines successfully started running 2 pipeline(s). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pending some suggestions about combining conditionals behind "ismultiplemutationenabled" flag. and nit about test separation. Otherwise looks good and approving so you can get those changes and merge on monday your time.
/azp run |
Azure Pipelines successfully started running 2 pipeline(s). |
/azp run |
Azure Pipelines successfully started running 2 pipeline(s). |
/azp run |
Azure Pipelines successfully started running 2 pipeline(s). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
unclear on check for MultipleCreateSupportingDatabaseType
/azp run |
Azure Pipelines successfully started running 2 pipeline(s). |
## Why make this change? - All code changes for **Multiple Create** feature was being merged into `dev/NestedMutations` branch. - This PR attempts to merge all these changes to the `main` branch in preparation for the `0.12.* rc1` release ## What is this change? - Right now, `dev/NestedMutations` branch contains the code changes for the following components of Multiple Create feature - Schema Generation - #1902 - AuthZ - #1943 - Feature flag - CLI changes #1983 - Feature flag - Re-naming changes #2103 - Feature flag - Engine changes #2116 - Each specified PR was reviewed before merging into `dev/NestedMutations` branch. - This PR aims to merge all the changes into `main` branch ## How was this tested? - [x] Unit, Integration and Manual tests were performed on each PR before merging into `dev/NestedMutations` --------- Co-authored-by: Shyam Sundar J <shyamsundarj@microsoft.com> Co-authored-by: Sean Leonard <sean.leonard@microsoft.com>
Why make this change?
MultipleMutationOptions
,MultipleCreateOptions
,GraphQLRuntimeOptions
objects are created accordingly.What is this change?
How was this tested?
Note: At the moment, multiple create operation is disabled in the config file generated for integration tests. This is because of the plan to merge in the Schema generation, AuthZ/N branches separately to the main branch. With just these 2 PRs, a multiple create operation will fail, hence, the disabling multiple create operation. At the moment, tests that perform validations specific to multiple create feature enable it by i) updating the runtime object (or) ii) creating a custom config in which the operation is enabled.
Sample Request(s)
When Multiple Create operation is enabled - MsSQL
Related entity fields are created in the input object type
Multiple type create operation is created in addition to point create operation
Querying related entities continue to work successfully
When Multiple Create operation is disabled - MsSQL
Only fields belonging to the given entity are created in the input object type
Multiple type create operation is not created
When Multiple Create operation is enabled - Other relational database types
Only fields belonging to the given entity are created in the input object type
Multiple type create operation is not created