You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
PR #2116 introduces a new parameter called isMultipleCreateOperationEnabled to CreateMutationBuilder.Build() method.
isMultipleCreateOperationEnabled can be computed using RuntimeConfig.IsMultipleCreateOperationEnabled(). CreateMutationBuilder.Build() method accepts another parameter called entities of type RuntimeEntities. This can be got from RuntimeConfig.RuntimeEntities
Evaulate if it is beneficial to refactor CreateMutationBuilder.Build() method to accept RuntimeConfig object instead of two parameters separately.
severussundar
changed the title
Refactor CreateMutation.Build() to accept RuntimeConfig object
Evaluate if refactor of CreateMutation.Build() to accept RuntimeConfig object is beneficial
Mar 26, 2024
Upon initial analysis, IMHO, this refactor offers little benefit as RuntimeEntities and IsMultipleCreate are the fields relevant/needed for schema generation. We don't necessarily need the entire RuntimeConfig object.
PR #2116 introduces a new parameter called
isMultipleCreateOperationEnabled
toCreateMutationBuilder.Build()
method.isMultipleCreateOperationEnabled
can be computed usingRuntimeConfig.IsMultipleCreateOperationEnabled()
.CreateMutationBuilder.Build()
method accepts another parameter calledentities
of typeRuntimeEntities
. This can be got fromRuntimeConfig.RuntimeEntities
Evaulate if it is beneficial to refactor
CreateMutationBuilder.Build()
method to acceptRuntimeConfig
object instead of two parameters separately.Original discussion: #2116 (comment)
The text was updated successfully, but these errors were encountered: