Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Evaluate if refactor of CreateMutation.Build() to accept RuntimeConfig object is beneficial #2132

Open
Tracked by #1576
severussundar opened this issue Mar 26, 2024 · 2 comments
Assignees
Labels
Multiple mutations Fixes/enhancements related to nested mutations. refactor
Milestone

Comments

@severussundar
Copy link
Contributor

PR #2116 introduces a new parameter called isMultipleCreateOperationEnabled to CreateMutationBuilder.Build() method.

isMultipleCreateOperationEnabled can be computed using RuntimeConfig.IsMultipleCreateOperationEnabled().
CreateMutationBuilder.Build() method accepts another parameter called entities of type RuntimeEntities. This can be got from RuntimeConfig.RuntimeEntities

Evaulate if it is beneficial to refactor CreateMutationBuilder.Build() method to accept RuntimeConfig object instead of two parameters separately.

Original discussion: #2116 (comment)

@severussundar severussundar added refactor Multiple mutations Fixes/enhancements related to nested mutations. labels Mar 26, 2024
@severussundar severussundar added this to the 0.12rc milestone Mar 26, 2024
@severussundar severussundar self-assigned this Mar 26, 2024
@severussundar severussundar changed the title Refactor CreateMutation.Build() to accept RuntimeConfig object Evaluate if refactor of CreateMutation.Build() to accept RuntimeConfig object is beneficial Mar 26, 2024
@severussundar
Copy link
Contributor Author

Upon initial analysis, IMHO, this refactor offers little benefit as RuntimeEntities and IsMultipleCreate are the fields relevant/needed for schema generation. We don't necessarily need the entire RuntimeConfig object.

Open to suggestions on other lines of thought.

@seantleonard seantleonard modified the milestones: 0.12rc, 1.2rc Mar 26, 2024
@seantleonard
Copy link
Contributor

not a priority for 0.12

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Multiple mutations Fixes/enhancements related to nested mutations. refactor
Projects
None yet
Development

No branches or pull requests

2 participants