Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GA endcall experience GA #4547

Merged
merged 9 commits into from
May 2, 2024
Merged

GA endcall experience GA #4547

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
a52f51b
GA endcall experience GA
PorterNan Apr 26, 2024
edca995
Merge branch 'main' into jinan/endcall-ux-ga
PorterNan Apr 26, 2024
41aa84d
Merge branch 'main' into jinan/endcall-ux-ga
PorterNan Apr 29, 2024
9192c32
Merge branch 'main' into jinan/endcall-ux-ga
PorterNan Apr 29, 2024
e035485
Merge branch 'main' into jinan/endcall-ux-ga
PorterNan Apr 30, 2024
78177ed
Merge branch 'main' into jinan/endcall-ux-ga
PorterNan May 1, 2024
5614993
Merge branch 'main' into jinan/endcall-ux-ga
PorterNan May 2, 2024
2bf30bd
Merge branch 'main' into jinan/endcall-ux-ga
PorterNan May 2, 2024
82abd0b
Merge branch 'main' into jinan/endcall-ux-ga
PorterNan May 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 3 additions & 3 deletions common/config/babel/features.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,8 +75,6 @@ module.exports = {
'image-overlay-theme',
// Feature for local recording notification for teams meetings
'local-recording-notification',
// Feature for end call options
'end-call-options',
// Close captions feature for ACS calls
"acs-close-captions",
// Feature for Rich Text Editor (RTE) support
Expand All @@ -90,11 +88,13 @@ module.exports = {
"video-stream-is-receiving-flag",
// Feature for spotlight
'spotlight',
// Feature for end of call survey
// Feature for end of call survey
'end-of-call-survey',
// Feature for PPT Live for teams meeting
'ppt-live',
// feature for hiding attendee name in the teams meeting
"hide-attendee-name",
// Feature for end call options
'end-call-options',
]
}
14 changes: 13 additions & 1 deletion packages/communication-react/review/stable/communication-react.api.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -583,16 +583,23 @@ export interface CallCompositeStrings {
dtmfDialerButtonTooltipOn?: string;
dtmfDialerMoreButtonLabelOff?: string;
dtmfDialerMoreButtonLabelOn?: string;
endCallConfirmButtonLabel?: string;
endCallConfirmDialogContent?: string;
endCallConfirmDialogTitle?: string;
endOfSurveyText: string;
exitSpotlightButtonLabel: string;
exitSpotlightButtonTooltip: string;
failedToJoinCallDueToNoNetworkMoreDetails?: string;
failedToJoinCallDueToNoNetworkTitle: string;
failedToJoinTeamsMeetingReasonAccessDeniedMoreDetails?: string;
failedToJoinTeamsMeetingReasonAccessDeniedTitle: string;
hangUpCancelButtonLabel?: string;
inviteToRoomRemovedDetails?: string;
inviteToRoomRemovedTitle: string;
learnMore: string;
leaveConfirmButtonLabel?: string;
leaveConfirmDialogContent?: string;
leaveConfirmDialogTitle?: string;
leavingCallTitle?: string;
leftCallMoreDetails?: string;
leftCallTitle: string;
Expand Down Expand Up @@ -1633,7 +1640,9 @@ export type CommonCallAdapterOptions = {
export type CommonCallControlOptions = {
displayType?: CallControlDisplayType;
cameraButton?: boolean;
endCallButton?: boolean;
endCallButton?: boolean | /* @conditional-compile-remove(end-call-options) */ {
hangUpForEveryone?: false | 'endCallOptions';
};
microphoneButton?: boolean;
devicesButton?: boolean;
participantsButton?: boolean | {
Expand Down Expand Up @@ -2432,13 +2441,16 @@ export const EndCallButton: (props: EndCallButtonProps) => JSX.Element;

// @public
export interface EndCallButtonProps extends ControlBarButtonProps {
enableEndCallMenu?: boolean;
onHangUp?: (forEveryone?: boolean) => Promise<void>;
strings?: EndCallButtonStrings;
}

// @public
export interface EndCallButtonStrings {
endCallOption?: string;
label: string;
leaveOption?: string;
tooltipContent?: string;
}

Expand Down