Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GA endcall experience GA #4547

Merged
merged 9 commits into from May 2, 2024
Merged

GA endcall experience GA #4547

merged 9 commits into from May 2, 2024

Conversation

PorterNan
Copy link
Member

What

Move endcall experience to stable section

Why

How Tested

Process & policy checklist

  • I have updated the project documentation to reflect my changes if necessary.
  • I have read the CONTRIBUTING documentation.

Is this a breaking change?

  • This change causes current functionality to break.

@PorterNan PorterNan requested review from a team as code owners April 26, 2024 23:00
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 26, 2024 •
edited

Chat bundle size is not changed.

  • Current size: 2150696
  • Base size: 2150696
  • Diff size: 0

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 26, 2024 •
edited

CallWithChat bundle size is not changed.

  • Current size: 6282798
  • Base size: 6282798
  • Diff size: 0

@github-actions GitHub Actions
Copy link
Contributor

Storybook URL https://60c7ae6891f0e90039d7cd54-ddcsovmkun.chromatic.com/

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 26, 2024 •
edited

Calling bundle size is not changed.

  • Current size: 4888203
  • Base size: 4888203
  • Diff size: 0

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 26, 2024 •
edited

@azure/communication-react jest test coverage for stable.

Lines Statements Functions Branches
Base 25305 / 39283
64.41%		 25305 / 39283
64.41%		 698 / 1230
56.74%		 2016 / 3196
63.07%
Current 25365 / 39347
64.46%		 25365 / 39347
64.46%		 698 / 1232
56.65%		 1996 / 3187
62.62%
Diff 60 / 64
0.05%		 60 / 64
0.05%		 0 / 2
-0.09%		 -20 / -9
-0.45%

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 26, 2024 •
edited

@azure/communication-react jest test coverage for beta.

Lines Statements Functions Branches
Base 49902 / 79373
62.87%		 49902 / 79373
62.87%		 1037 / 2301
45.06%		 2903 / 4780
60.73%
Current 49908 / 79373
62.87%		 49908 / 79373
62.87%		 1037 / 2301
45.06%		 2935 / 4802
61.12%
Diff 6 / 0
0%		 6 / 0
0%		 0 / 0
0%		 32 / 22
0.39%

@github-actions GitHub Actions
Copy link
Contributor

Storybook URL https://60c7ae6891f0e90039d7cd54-chzcrdjcds.chromatic.com/

@github-actions GitHub Actions
Copy link
Contributor

Storybook URL https://60c7ae6891f0e90039d7cd54-mjmnsnxete.chromatic.com/

@github-actions GitHub Actions
Copy link
Contributor

Storybook URL https://60c7ae6891f0e90039d7cd54-zzqzkfriwu.chromatic.com/

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 1, 2024

Storybook URL https://60c7ae6891f0e90039d7cd54-cruunzabqa.chromatic.com/

@PorterNan PorterNan enabled auto-merge (squash) May 2, 2024 16:58
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 2, 2024

Storybook URL https://60c7ae6891f0e90039d7cd54-nkamlofiiu.chromatic.com/

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 2, 2024

Storybook URL https://60c7ae6891f0e90039d7cd54-tkcsrzuleh.chromatic.com/

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 2, 2024

Storybook URL https://60c7ae6891f0e90039d7cd54-mufpadevjk.chromatic.com/

@PorterNan PorterNan merged commit 566e097 into main May 2, 2024
41 checks passed
@PorterNan PorterNan deleted the jinan/endcall-ux-ga branch May 2, 2024 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mgamis-msft mgamis-msft mgamis-msft approved these changes

@dmceachernmsft dmceachernmsft dmceachernmsft approved these changes

@JamesBurnside JamesBurnside Awaiting requested review from JamesBurnside JamesBurnside is a code owner automatically assigned from Azure/acs-ui-web-calling-reviewer-1

@alkwa-msft alkwa-msft Awaiting requested review from alkwa-msft alkwa-msft is a code owner automatically assigned from Azure/acs-ui-web-calling-reviewer-1

@carocao-msft carocao-msft Awaiting requested review from carocao-msft carocao-msft is a code owner automatically assigned from Azure/acs-ui-web-calling-reviewer-1

@edwardlee-msft edwardlee-msft Awaiting requested review from edwardlee-msft edwardlee-msft is a code owner automatically assigned from Azure/acs-ui-web-calling-reviewer-1

@prabhjot-msft prabhjot-msft Awaiting requested review from prabhjot-msft prabhjot-msft is a code owner automatically assigned from Azure/acs-ui-web-calling-reviewer-2

@AmyL219 AmyL219 Awaiting requested review from AmyL219 AmyL219 is a code owner automatically assigned from Azure/acs-ui-web-chat-reviewer-1

@jimchou-dev jimchou-dev Awaiting requested review from jimchou-dev jimchou-dev is a code owner automatically assigned from Azure/acs-ui-web-chat-reviewer-1

@vhuseinova-msft vhuseinova-msft Awaiting requested review from vhuseinova-msft vhuseinova-msft is a code owner automatically assigned from Azure/acs-ui-web-chat-reviewer-1

@Leah-Xia-Microsoft Leah-Xia-Microsoft Awaiting requested review from Leah-Xia-Microsoft Leah-Xia-Microsoft is a code owner automatically assigned from Azure/acs-ui-web-chat-reviewer-1

@jpeng-ms jpeng-ms Awaiting requested review from jpeng-ms jpeng-ms is a code owner automatically assigned from Azure/acs-ui-web-chat-reviewer-1

@waynemo waynemo Awaiting requested review from waynemo waynemo is a code owner automatically assigned from Azure/acs-ui-web-chat-reviewer-2

@emlynmac emlynmac Awaiting requested review from emlynmac emlynmac is a code owner automatically assigned from Azure/acs-ui-web-chat-reviewer-2

@JoshuaLai JoshuaLai Awaiting requested review from JoshuaLai JoshuaLai is a code owner automatically assigned from Azure/acs-ui-web-chat-reviewer-2

@palatter palatter Awaiting requested review from palatter palatter is a code owner automatically assigned from Azure/acs-ui-web-chat-reviewer-2

Assignees

@mgamis-msft mgamis-msft

@dmceachernmsft dmceachernmsft

@carocao-msft carocao-msft

@edwardlee-msft edwardlee-msft

Labels
breaking-change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@PorterNan @mgamis-msft @dmceachernmsft @carocao-msft @edwardlee-msft