Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Storybook] Split button doc #4515

Merged
merged 9 commits into from
Apr 30, 2024
Merged

[Storybook] Split button doc #4515

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
acec96e
remove beta banners
dmceachernmsft Apr 23, 2024
3975662
Change files
dmceachernmsft Apr 23, 2024
e70adb3
fix lint
dmceachernmsft Apr 23, 2024
59a0c67
fix lint
dmceachernmsft Apr 24, 2024
bd8d67d
Merge branch 'main' into dmceachernmsft/split-button-doc
dmceachernmsft Apr 24, 2024
97f009e
Merge branch 'main' into dmceachernmsft/split-button-doc
dmceachernmsft Apr 24, 2024
1ef5b9a
Merge branch 'main' into dmceachernmsft/split-button-doc
dmceachernmsft Apr 25, 2024
b6e6547
Merge branch 'main' into dmceachernmsft/split-button-doc
dmceachernmsft Apr 25, 2024
492fddd
Merge branch 'main' into dmceachernmsft/split-button-doc
dmceachernmsft Apr 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
9 changes: 9 additions & 0 deletions change/@azure-communication-react-5e86ae5b-6832-4e90-ad70-0d8f6d1a23a2.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
{
"type": "none",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to remove this none type changelog

"area": "fix",
"workstream": "Storybook",
"comment": "Remove beta banners for device split buttons",
"packageName": "@azure/communication-react",
"email": "dmceachern@microsoft.com",
"dependentChangeType": "none"
}
2 changes: 0 additions & 2 deletions packages/storybook/stories/ControlBar/Buttons/Camera/Camera.stories.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@ import { Canvas, Description, Heading, Props, Source, Title } from '@storybook/a
import { Meta } from '@storybook/react/types-6-0';
import React, { useState } from 'react';

import { SingleLineBetaBanner } from '../../../BetaBanners/SingleLineBetaBanner';
import { COMPONENT_FOLDER_PREFIX } from '../../../constants';
import { controlsToAdd, defaultControlsCameras, hiddenControl } from '../../../controlsUtils';
import { CustomCameraButtonExample } from './snippets/Custom.snippet';
Expand Down Expand Up @@ -57,7 +56,6 @@ const getDocs: () => JSX.Element = () => {
</Canvas>

<Heading>Camera with device selection menu</Heading>
<SingleLineBetaBanner />
<Description>
`CameraButton` can be optionally rendered as a split button. The secondary button in this mode opens a menu
where users can select the camera to use. To render `CameraButton` in this mode, set the
Expand Down
2 changes: 0 additions & 2 deletions packages/storybook/stories/ControlBar/Buttons/Microphone/Microphone.stories.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@ import { Canvas, Description, Heading, Props, Source, Title } from '@storybook/a
import { Meta } from '@storybook/react/types-6-0';
import React, { useState } from 'react';

import { SingleLineBetaBanner } from '../../../BetaBanners/SingleLineBetaBanner';
import { COMPONENT_FOLDER_PREFIX } from '../../../constants';
import {
controlsToAdd,
Expand Down Expand Up @@ -62,7 +61,6 @@ const getDocs: () => JSX.Element = () => {
</Canvas>

<Heading>Microphone with device selection menu</Heading>
<SingleLineBetaBanner />
<Description>
`MicrophoneButton` can be optionally rendered as a split button. The secondary button in this mode opens a menu
where users can select the audio devices to use. To render `MicrophoneButton` in this mode, set the
Expand Down