Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Storybook] Split button doc #4515

Merged
merged 9 commits into from Apr 30, 2024
Merged

[Storybook] Split button doc #4515

merged 9 commits into from Apr 30, 2024

Conversation

dmceachernmsft
Copy link
Member

What

Remove the beta banners for the mic and camera split buttons
image

Why

These are in GA so we don't need this in our docs anymore

How Tested

Validated locally

@dmceachernmsft dmceachernmsft requested review from a team as code owners April 23, 2024 23:03
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 23, 2024 •
edited

CallWithChat bundle size is not changed.

  • Current size: 6275320
  • Base size: 6275320
  • Diff size: 0

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 23, 2024 •
edited

Chat bundle size is not changed.

  • Current size: 2150697
  • Base size: 2150697
  • Diff size: 0

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 23, 2024 •
edited

Calling bundle size is not changed.

  • Current size: 4880725
  • Base size: 4880725
  • Diff size: 0

@github-actions GitHub Actions
Copy link
Contributor

Storybook URL https://60c7ae6891f0e90039d7cd54-zirdlublua.chromatic.com/

@github-actions GitHub Actions
Copy link
Contributor

Storybook URL https://60c7ae6891f0e90039d7cd54-olidyzfagn.chromatic.com/

@github-actions GitHub Actions
Copy link
Contributor

Storybook URL https://60c7ae6891f0e90039d7cd54-btccxzdhxv.chromatic.com/

@github-actions GitHub Actions
Copy link
Contributor

Storybook URL https://60c7ae6891f0e90039d7cd54-mpetszwbko.chromatic.com/

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 24, 2024 •
edited

@azure/communication-react jest test coverage for stable.

Lines Statements Functions Branches
Base 25305 / 39283
64.41%		 25305 / 39283
64.41%		 698 / 1230
56.74%		 2010 / 3192
62.96%
Current 25305 / 39283
64.41%		 25305 / 39283
64.41%		 698 / 1230
56.74%		 2009 / 3191
62.95%
Diff 0 / 0
0%		 0 / 0
0%		 0 / 0
0%		 -1 / -1
-0.01%

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 24, 2024 •
edited

@azure/communication-react jest test coverage for beta.

Lines Statements Functions Branches
Base 49939 / 79373
62.91%		 49939 / 79373
62.91%		 1037 / 2301
45.06%		 2953 / 4806
61.44%
Current 49908 / 79373
62.87%		 49908 / 79373
62.87%		 1037 / 2301
45.06%		 2930 / 4799
61.05%
Diff -31 / 0
-0.04%		 -31 / 0
-0.04%		 0 / 0
0%		 -23 / -7
-0.39%

@github-actions GitHub Actions
Copy link
Contributor

Storybook URL https://60c7ae6891f0e90039d7cd54-pjwwqlkauh.chromatic.com/

@github-actions GitHub Actions
Copy link
Contributor

Storybook URL https://60c7ae6891f0e90039d7cd54-ivxyleewna.chromatic.com/

carocao-msft
carocao-msft reviewed Apr 25, 2024
View reviewed changes
change/@azure-communication-react-5e86ae5b-6832-4e90-ad70-0d8f6d1a23a2.json
@@ -0,0 +1,9 @@
{
"type": "none",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to remove this none type changelog

@dmceachernmsft dmceachernmsft enabled auto-merge (squash) April 25, 2024 21:00
@github-actions GitHub Actions
Copy link
Contributor

Storybook URL https://60c7ae6891f0e90039d7cd54-xzrdegfktu.chromatic.com/

@github-actions GitHub Actions
Copy link
Contributor

Storybook URL https://60c7ae6891f0e90039d7cd54-bplfjdeuul.chromatic.com/

@dmceachernmsft dmceachernmsft merged commit bc42edf into main Apr 30, 2024
41 checks passed
@dmceachernmsft dmceachernmsft deleted the dmceachernmsft/split-button-doc branch April 30, 2024 20:39
mgamis-msft pushed a commit that referenced this pull request May 1, 2024
@dmceachernmsft @mgamis-msft
[Storybook] Split button doc (#4515)
3cd7d35 
* remove beta banners

* Change files

* fix lint

* fix lint
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carocao-msft carocao-msft carocao-msft left review comments

@JamesBurnside JamesBurnside JamesBurnside approved these changes

@prabhjot-msft prabhjot-msft prabhjot-msft approved these changes

@alkwa-msft alkwa-msft Awaiting requested review from alkwa-msft alkwa-msft is a code owner automatically assigned from Azure/acs-ui-web-calling-reviewer-1

@edwardlee-msft edwardlee-msft Awaiting requested review from edwardlee-msft edwardlee-msft is a code owner automatically assigned from Azure/acs-ui-web-calling-reviewer-1

@PorterNan PorterNan Awaiting requested review from PorterNan PorterNan is a code owner automatically assigned from Azure/acs-ui-web-calling-reviewer-2

@mgamis-msft mgamis-msft Awaiting requested review from mgamis-msft mgamis-msft is a code owner automatically assigned from Azure/acs-ui-web-calling-reviewer-2

@AmyL219 AmyL219 Awaiting requested review from AmyL219 AmyL219 is a code owner automatically assigned from Azure/acs-ui-web-chat-reviewer-1

@jimchou-dev jimchou-dev Awaiting requested review from jimchou-dev jimchou-dev is a code owner automatically assigned from Azure/acs-ui-web-chat-reviewer-1

@vhuseinova-msft vhuseinova-msft Awaiting requested review from vhuseinova-msft vhuseinova-msft is a code owner automatically assigned from Azure/acs-ui-web-chat-reviewer-1

@Leah-Xia-Microsoft Leah-Xia-Microsoft Awaiting requested review from Leah-Xia-Microsoft Leah-Xia-Microsoft is a code owner automatically assigned from Azure/acs-ui-web-chat-reviewer-1

@jpeng-ms jpeng-ms Awaiting requested review from jpeng-ms jpeng-ms is a code owner automatically assigned from Azure/acs-ui-web-chat-reviewer-1

@waynemo waynemo Awaiting requested review from waynemo waynemo is a code owner automatically assigned from Azure/acs-ui-web-chat-reviewer-2

@emlynmac emlynmac Awaiting requested review from emlynmac emlynmac is a code owner automatically assigned from Azure/acs-ui-web-chat-reviewer-2

@JoshuaLai JoshuaLai Awaiting requested review from JoshuaLai JoshuaLai is a code owner automatically assigned from Azure/acs-ui-web-chat-reviewer-2

@palatter palatter Awaiting requested review from palatter palatter is a code owner automatically assigned from Azure/acs-ui-web-chat-reviewer-2

Assignees

@carocao-msft carocao-msft

@prabhjot-msft prabhjot-msft

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@dmceachernmsft @JamesBurnside @carocao-msft @prabhjot-msft