Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Radiology insights GA #39813

Open
wants to merge 51 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from 45 commits
Commits
Show all changes
51 commits
Select commit Hold shift + click to select a range
ec1db92
First version
hvanhoe Mar 19, 2024
9a66798
Checking for null
hvanhoe Mar 19, 2024
57946eb
Better exception handling
hvanhoe Mar 19, 2024
732ebf6
Improved Exception handling
hvanhoe Mar 20, 2024
5cfa0ea
Extra tests and test assets
hvanhoe Apr 4, 2024
5c2fa0f
Update tsp-location.yaml with latest commit id
koen-mertens Apr 4, 2024
07636d6
Extra tests
hvanhoe Apr 9, 2024
966bed8
Merge branch 'radiology-insights-GA' of https://github.com/koen-merte…
hvanhoe Apr 9, 2024
ea08833
SDK regenerated + tests and samples adapted
hvanhoe Apr 10, 2024
4d461b5
Using unique or random job ids
hvanhoe Apr 10, 2024
5a5d024
Updated assets
hvanhoe Apr 10, 2024
373a71c
Improved exception handling
hvanhoe Apr 15, 2024
1e8952e
Merge branch 'main' into radiology-insights-GA
hvanhoe Apr 15, 2024
1fe7638
Extra tests
hvanhoe Apr 16, 2024
9d8159d
Updated assets
hvanhoe Apr 16, 2024
4155c0a
Updated documentation
hvanhoe Apr 17, 2024
d6d41ed
Merge branch 'Azure:main' into radiology-insights-GA
koen-mertens Apr 19, 2024
f7c06ff
fix 2 typos
koen-mertens Apr 22, 2024
5d3a6b4
Updating dependencies
hvanhoe Apr 23, 2024
72cb866
Reenabled test of evidence
hvanhoe Apr 23, 2024
7f4d665
Updated assets
hvanhoe Apr 23, 2024
6f9dcf6
Merge branch 'Azure:main' into radiology-insights-GA
hvanhoe Apr 25, 2024
7bcdae0
New RI version
Apr 29, 2024
f0d1a45
Replaced tabs with spaces
hvanhoe Apr 29, 2024
25670d6
Updated assets
hvanhoe Apr 29, 2024
cf8902e
Merge branch 'Azure:main' into radiology-insights-GA
hvanhoe Apr 30, 2024
052d435
Spellcheck exceptions for radiologyinsights samples
Apr 30, 2024
99c9184
Merge branch 'Azure:main' into radiology-insights-GA
koen-mertens May 3, 2024
eec3a01
Update CODEOWNERS
koen-mertens May 3, 2024
8c2e6c3
Merge branch 'radiology-insights-GA' of https://github.com/koen-merte…
koen-mertens May 3, 2024
4fbfffb
Update CHANGELOG.md
koen-mertens May 3, 2024
7c622ce
Update version for GA release
koen-mertens May 3, 2024
cdd84e6
Update .github/CODEOWNERS
koen-mertens May 3, 2024
98b89c6
Merge branch 'Azure:main' into radiology-insights-GA
koen-mertens May 3, 2024
561691e
Update pom.xml
koen-mertens May 6, 2024
3f1b0be
Merge branch 'Azure:main' into radiology-insights-GA
hvanhoe May 6, 2024
acdae6f
SDK update
hvanhoe May 6, 2024
f7eb951
Merge branch 'main' into radiology-insights-GA
koen-mertens May 7, 2024
c618728
Update CHANGELOG.md
koen-mertens May 7, 2024
163855d
Merge branch 'Azure:main' into radiology-insights-GA
hvanhoe May 8, 2024
c6d138f
Regenerated SDK to remove Encounter class
hvanhoe May 8, 2024
f523384
Surrounded variables with backticks
hvanhoe May 8, 2024
7d93eb1
Cleaned up the code
hvanhoe May 8, 2024
3cdb7e6
Merge branch 'Azure:main' into radiology-insights-GA
hvanhoe May 8, 2024
f4171bb
Regenerate SDK to fix analyze step
hvanhoe May 8, 2024
6005337
Merge remote-tracking branch 'origin/main' into radiology-insights-GA
hvanhoe May 23, 2024
1db5b2f
Merge branch 'Azure:main' into radiology-insights-GA
hvanhoe May 23, 2024
8e81d50
Regenerated SDK to sync after merge
hvanhoe May 23, 2024
53a02d3
Replacing timestamp with UUID
hvanhoe May 23, 2024
0efbcf6
Completed changelog
hvanhoe May 27, 2024
86ca8ba
Features added + 2 field changes that were still missing
hvanhoe May 27, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 6 additions & 0 deletions .github/CODEOWNERS
Validating CODEOWNERS rules …
Original file line number Diff line number Diff line change
Expand Up @@ -241,6 +241,12 @@
# ServiceLabel: %Cognitive - Mgmt
# ServiceOwners: @yangyuan

# PRLabel: %Cognitive - Health Insights
/sdk/healthinsights/ @tomsft @koen-mertens

# ServiceLabel: %Cognitive - Health Insights
# ServiceOwners: @tomsft @koen-mertens

# ServiceLabel: %Commerce
# ServiceOwners: @ms-premp @qiaozha

Expand Down
8 changes: 8 additions & 0 deletions .vscode/cspell.json
Original file line number Diff line number Diff line change
Expand Up @@ -555,6 +555,14 @@
"docid"
]
},
{
"filename": "sdk/healthinsights/azure-health-insights-radiologyinsights/**",
"words": [
"pericholecystic",
"craniocaudally",
"angiomyolipomas"
]
},
{
"filename": "sdk/easm/*",
"words": [
Expand Down
2 changes: 1 addition & 1 deletion eng/versioning/version_client.txt
Original file line number Diff line number Diff line change
Expand Up @@ -126,7 +126,7 @@ com.azure:azure-digitaltwins-core;1.3.19;1.4.0-beta.1
com.azure:azure-e2e;1.0.0-beta.1;1.0.0-beta.1
com.azure:azure-health-insights-clinicalmatching;1.0.0-beta.1;1.0.0-beta.2
com.azure:azure-health-insights-cancerprofiling;1.0.0-beta.1;1.0.0-beta.2
com.azure:azure-health-insights-radiologyinsights;1.0.0-beta.1;1.0.0-beta.2
com.azure:azure-health-insights-radiologyinsights;1.0.0-beta.1;1.0.0
koen-mertens marked this conversation as resolved.
Show resolved Hide resolved
com.azure:azure-identity;1.12.1;1.13.0-beta.1
com.azure:azure-identity-extensions;1.1.15;1.2.0-beta.2
com.azure:azure-identity-broker;1.1.1;1.2.0-beta.1
Expand Down
Original file line number Diff line number Diff line change
@@ -1,14 +1,22 @@
# Release History

## 1.0.0-beta.2 (Unreleased)
## 1.0.0 (2024-05-03)

### Features Added
- GA release
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If there are changes to the public surface area of the SDK, such as model renames or changes to properties, we should call those out here for customers to refer to when upgrading from the beta to the stable version of the library.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, I will list all changes

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I listed all relevant changes in CHANGELOG.md


### Breaking Changes

### Bugs Fixed

### Other Changes
- Client Changes
- POST call replaced with PUT
- Request changes:
- Renamed `createdDateTime` into `createdAt`
- `PatientInfo` renamed into `PatientDetails`
- Unique ID required to be added in the request parameters
- Response changes:
- `dateTime` field on FollowupCommunication renamed into `communicatedAt` field
- Renamed `createdDateTime` into `createdAt`
- Renamed `expirationDateTime` into `expiresAt`
- Renamed `lastUpdateDateTime` into `updatedAt`

## 1.0.0-beta.1 (2024-02-15)

Expand Down
512 changes: 495 additions & 17 deletions sdk/healthinsights/azure-health-insights-radiologyinsights/README.md

Large diffs are not rendered by default.

Original file line number Diff line number Diff line change
Expand Up @@ -2,5 +2,5 @@
"AssetsRepo": "Azure/azure-sdk-assets",
"AssetsRepoPrefixPath": "java",
"TagPrefix": "java/healthinsights/azure-health-insights-radiologyinsights",
"Tag": "java/healthinsights/azure-health-insights-radiologyinsights_bfa09b377c"
"Tag": "java/healthinsights/azure-health-insights-radiologyinsights_4d1898544b"
}
koen-mertens marked this conversation as resolved.
Show resolved Hide resolved
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@

<groupId>com.azure</groupId>
<artifactId>azure-health-insights-radiologyinsights</artifactId>
<version>1.0.0-beta.2</version> <!-- {x-version-update;com.azure:azure-health-insights-radiologyinsights;current} -->
<version>1.0.0</version> <!-- {x-version-update;com.azure:azure-health-insights-radiologyinsights;current} -->
<packaging>jar</packaging>

<name>Microsoft Azure client library for Health Insights - Radiology Insights</name>
Expand Down Expand Up @@ -43,8 +43,8 @@
</developers>
<properties>
<project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
<jacoco.min.linecoverage>0.2</jacoco.min.linecoverage>
<jacoco.min.branchcoverage>0.2</jacoco.min.branchcoverage>
<jacoco.min.linecoverage>0.3</jacoco.min.linecoverage>
<jacoco.min.branchcoverage>0.15</jacoco.min.branchcoverage>
</properties>
<dependencies>
<dependency>
Expand Down Expand Up @@ -93,11 +93,6 @@
<version>1.7.36</version> <!-- {x-version-update;org.slf4j:slf4j-simple;external_dependency} -->
<scope>test</scope>
</dependency>
<dependency>
<groupId>com.azure</groupId>
<artifactId>azure-core-experimental</artifactId>
<version>1.0.0-beta.50</version> <!-- {x-version-update;com.azure:azure-core-experimental;dependency} -->
</dependency>
</dependencies>
<build>
<plugins>
Expand Down

Large diffs are not rendered by default.

Large diffs are not rendered by default.

Original file line number Diff line number Diff line change
Expand Up @@ -11,9 +11,9 @@
*/
public enum RadiologyInsightsServiceVersion implements ServiceVersion {
/**
* Enum value 2023-09-01-preview.
* Enum value 2024-04-01.
*/
V2023_09_01_PREVIEW("2023-09-01-preview");
V2024_04_01("2024-04-01");

private final String version;

Expand All @@ -35,6 +35,6 @@ public String getVersion() {
* @return The latest {@link RadiologyInsightsServiceVersion}.
*/
public static RadiologyInsightsServiceVersion getLatest() {
return V2023_09_01_PREVIEW;
return V2024_04_01;
}
}

Large diffs are not rendered by default.

Original file line number Diff line number Diff line change
Expand Up @@ -38,8 +38,8 @@ public final class FollowupCommunicationInference extends RadiologyInsightsInfer
* Communication date and time.
*/
@Generated
@JsonProperty(value = "dateTime")
private List<OffsetDateTime> dateTime;
@JsonProperty(value = "communicatedAt")
private List<OffsetDateTime> communicatedAt;

/*
* Recipient of the communication.
Expand All @@ -53,17 +53,17 @@ public final class FollowupCommunicationInference extends RadiologyInsightsInfer
*/
@Generated
@JsonProperty(value = "wasAcknowledged")
private final boolean wasAcknowledged;
private final boolean acknowledged;

/**
* Creates an instance of FollowupCommunicationInference class.
*
* @param wasAcknowledged the wasAcknowledged value to set.
* @param acknowledged the acknowledged value to set.
*/
@Generated
@JsonCreator
private FollowupCommunicationInference(@JsonProperty(value = "wasAcknowledged") boolean wasAcknowledged) {
this.wasAcknowledged = wasAcknowledged;
private FollowupCommunicationInference(@JsonProperty(value = "wasAcknowledged") boolean acknowledged) {
this.acknowledged = acknowledged;
}

/**
Expand All @@ -78,13 +78,13 @@ public RadiologyInsightsInferenceType getKind() {
}

/**
* Get the dateTime property: Communication date and time.
* Get the communicatedAt property: Communication date and time.
*
* @return the dateTime value.
* @return the communicatedAt value.
*/
@Generated
public List<OffsetDateTime> getDateTime() {
return this.dateTime;
public List<OffsetDateTime> getCommunicatedAt() {
return this.communicatedAt;
}

/**
Expand All @@ -98,12 +98,12 @@ public List<MedicalProfessionalType> getRecipient() {
}

/**
* Get the wasAcknowledged property: Communication was acknowledged.
* Get the acknowledged property: Communication was acknowledged.
*
* @return the wasAcknowledged value.
* @return the acknowledged value.
*/
@Generated
public boolean isWasAcknowledged() {
return this.wasAcknowledged;
public boolean isAcknowledged() {
return this.acknowledged;
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -37,8 +37,8 @@ public final class FollowupRecommendationInference extends RadiologyInsightsInfe
* Date and time are displayed when the procedure is recommended to be done at a specific point in time.
*/
@Generated
@JsonProperty(value = "effectiveDateTime")
private String effectiveDateTime;
@JsonProperty(value = "effectiveAt")
private String effectiveAt;

/*
* The period is shown if a specific period is mentioned, with a start and end date-time.
Expand Down Expand Up @@ -123,14 +123,14 @@ public RadiologyInsightsInferenceType getKind() {
}

/**
* Get the effectiveDateTime property: Date and time are displayed when the procedure is recommended to be done at a
* Get the effectiveAt property: Date and time are displayed when the procedure is recommended to be done at a
* specific point in time.
*
* @return the effectiveDateTime value.
* @return the effectiveAt value.
*/
@Generated
public String getEffectiveDateTime() {
return this.effectiveDateTime;
public String getEffectiveAt() {
return this.effectiveAt;
}

/**
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,77 @@
// Copyright (c) Microsoft Corporation. All rights reserved.
// Licensed under the MIT License.
// Code generated by Microsoft (R) TypeSpec Code Generator.
package com.azure.health.insights.radiologyinsights.models;

import com.azure.core.annotation.Generated;
import com.azure.core.util.ExpandableStringEnum;
import com.fasterxml.jackson.annotation.JsonCreator;
import java.util.Collection;

/**
* The status of the processing job.
*/
public final class JobStatus extends ExpandableStringEnum<JobStatus> {

/**
* Static value notStarted for JobStatus.
*/
@Generated
public static final JobStatus NOT_STARTED = fromString("notStarted");

/**
* Static value running for JobStatus.
*/
@Generated
public static final JobStatus RUNNING = fromString("running");

/**
* Static value succeeded for JobStatus.
*/
@Generated
public static final JobStatus SUCCEEDED = fromString("succeeded");

/**
* Static value failed for JobStatus.
*/
@Generated
public static final JobStatus FAILED = fromString("failed");

/**
* Static value canceled for JobStatus.
*/
@Generated
public static final JobStatus CANCELED = fromString("canceled");

/**
* Creates a new instance of JobStatus value.
*
* @deprecated Use the {@link #fromString(String)} factory method.
*/
@Generated
@Deprecated
public JobStatus() {
}

/**
* Creates or finds a JobStatus from its string representation.
*
* @param name a name to look for.
* @return the corresponding JobStatus.
*/
@Generated
@JsonCreator
public static JobStatus fromString(String name) {
return fromString(name, JobStatus.class);
}

/**
* Gets known JobStatus values.
*
* @return known JobStatus values.
*/
@Generated
public static Collection<JobStatus> values() {
return values(JobStatus.class);
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -14,13 +14,6 @@
@Fluent
public final class OrderedProcedure {

/*
* Additional Content defined by implementations
*/
@Generated
@JsonProperty(value = "extension")
private List<FhirR4Extension> extension;

/*
* Procedure code
*/
Expand All @@ -35,33 +28,18 @@ public final class OrderedProcedure {
@JsonProperty(value = "description")
private String description;

/**
* Creates an instance of OrderedProcedure class.
*/
@Generated
public OrderedProcedure() {
}

/**
* Get the extension property: Additional Content defined by implementations.
*
* @return the extension value.
/*
* Additional Content defined by implementations
*/
@Generated
public List<FhirR4Extension> getExtension() {
return this.extension;
}
@JsonProperty(value = "extension")
private List<FhirR4Extension> extension;

/**
* Set the extension property: Additional Content defined by implementations.
*
* @param extension the extension value to set.
* @return the OrderedProcedure object itself.
* Creates an instance of OrderedProcedure class.
*/
@Generated
public OrderedProcedure setExtension(List<FhirR4Extension> extension) {
this.extension = extension;
return this;
public OrderedProcedure() {
}

/**
Expand Down Expand Up @@ -107,4 +85,26 @@ public OrderedProcedure setDescription(String description) {
this.description = description;
return this;
}

/**
* Get the extension property: Additional Content defined by implementations.
*
* @return the extension value.
*/
@Generated
public List<FhirR4Extension> getExtension() {
return this.extension;
}

/**
* Set the extension property: Additional Content defined by implementations.
*
* @param extension the extension value to set.
* @return the OrderedProcedure object itself.
*/
@Generated
public OrderedProcedure setExtension(List<FhirR4Extension> extension) {
this.extension = extension;
return this;
}
}