Radiology insights GA #39813
Radiology insights GA #39813
Conversation
…ns/azure-sdk-for-java.git into radiology-insights-GA
|
API change check APIView has identified API level changes in this PR and created following API reviews. |
koen-mertens
requested review from
alzimmermsft,
samvaity,
g2vinay and
JimSuplizio
as code owners
Co-authored-by: Jesse Squire <jesse.squire@gmail.com>
| ### Bugs Fixed | ||
|
|
||
| ### Other Changes | ||
| - GA release |
There was a problem hiding this comment.
If there are changes to the public surface area of the SDK, such as model renames or changes to properties, we should call those out here for customers to refer to when upgrading from the beta to the stable version of the library.
There was a problem hiding this comment.
OK, I will list all changes
| @@ -84,26 +90,28 @@ Infer radiology insights from a patient's radiology report using a **synchronous | |||
| - [SampleCriticalResultInferenceSync.java][ri_sync_sample] | |||
|
|
|||
| ```java com.azure.health.insights.radiologyinsights.inferradiologyinsightssync | |||
| RadiologyInsightsInferenceResult riResults = radiologyInsightsClient.beginInferRadiologyInsights(createRadiologyInsightsRequest()).getFinalResult(); | |||
| RadiologyInsightsJob riJobResponse = radiologyInsightsClient.beginInferRadiologyInsights("job" + new Date().getTime(), createRadiologyInsightsJob()).getFinalResult(); | |||
There was a problem hiding this comment.
Nit: the previous variable name seems better.
Also what is the new parameter for in this method?
There was a problem hiding this comment.
There was a POST to PUT change which requires now your own unique jobID to be set.
This also impacts the result we get back which is wrapped into a RadiologyInsightsJob object. The InferenceResult is nested in that one
There was a problem hiding this comment.
Usually GUID is better than the "current date".
sdk/healthinsights/azure-health-insights-radiologyinsights/pom.xml
Outdated
Show resolved
Hide resolved
.../src/main/resources/META-INF/azure-health-insights-radiologyinsights_apiview_properties.json
Show resolved
Hide resolved
|
There is Do we have a decision on this? |
sdk/healthinsights/azure-health-insights-radiologyinsights/CHANGELOG.md
Outdated
Show resolved
Hide resolved
.../src/test/java/com/azure/health/insights/radiologyinsights/RadiologyInsightsFindingTest.java
Outdated
Show resolved
Hide resolved
That has been discussed and the current decision was not to have a shared lib. |
|
There is discussion of the method signature of the LRO API in apiview Please reach a decision (if possible in SDK review meeting, for cross-language agreement). I can help you customize this API whatever the decision be (the customize on method parameter should be very simple; the customize on method return would need some knowledge). Ping me when you need my help. |
| RadiologyInsightsClientBuilder clientBuilder = new RadiologyInsightsClientBuilder() | ||
| .endpoint(endpoint).serviceVersion(RadiologyInsightsServiceVersion.getLatest()); | ||
| if (apiKey != null && !apiKey.equals("")) { | ||
| clientBuilder = clientBuilder.credential(new AzureKeyCredential(apiKey)); |
There was a problem hiding this comment.
Does service support AAD (Microsoft Entra ID)? If yes, we at least want to provide sample on that (you know, the Security initiative).
Description
Please add an informative description that covers that changes made by the pull request and link all relevant issues.
If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
All SDK Contribution checklist:
General Guidelines and Best Practices
Testing Guidelines