Fixed chained dead key behavior #331
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the bug describe in https://www.autohotkey.com/boards/viewtopic.php?f=14&t=125016
This will also fix https://www.autohotkey.com/boards/viewtopic.php?f=76&t=68434
and all layout that uses chained dead keys (Windows seems to ship some according to https://kbdlayout.info/features/deadkeys)
As far as my testing goes, single dead keys are still working the expected way.
Also, nothing has been done in the UWP case as nothing can be done: UWP apps doesn’t manage chained dead keys at all from my tests (no AHK involved and it doesn’t work). I’m planning opening a ticket for MS, but I don’t know where, and UWP are supposed to be dropped by MS anyway.
Let me know if more work is needed :)