feat: remove orphan objects if copy fails at any point #531
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeqo
force-pushed
the
jeqo/delete-orphan-files
branch
2 times, most recently
from
3d52a4e
to
c532ed6
Compare
ivanyu
reviewed
Apr 5, 2024
core/src/main/java/io/aiven/kafka/tieredstorage/manifest/SegmentManifestV1.java
Outdated
Show resolved
Hide resolved
jeqo
force-pushed
the
jeqo/delete-orphan-files
branch
from
c532ed6
to
cdffc7f
Compare
This was referenced Apr 8, 2024
RSM upload steps are messy and hard to read, mainly because of the encryption metadata. By moving the instantiation to the data key and aad, we can separate the upload stages clearly.
Given that there are at least 3 objects uploaded per segment, and it could fail at any stage, the plugin should guard that the chances for orphan objects is minimal.
jeqo
force-pushed
the
jeqo/delete-orphan-files
branch
from
cdffc7f
to
b732512
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Given that there are at least 3 objects uploaded per segment, and it could fail at any stage, the plugin should guard that the chances for orphan objects is minimal.
Be aware, the first commit includes a set of refactoring around RSM upload operations to cleanup and simplify the testing of the 2nd (main) commit. See commit messages for more details.