feat: add upload from file to storage backend #537
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mwea
reviewed
Apr 12, 2024
|
|
||
| public interface ObjectUploader { | ||
| /** | ||
| * @param inputStream content to upload. Not closed as part of the upload. | ||
| * @param key path to an object within a storage backend. | ||
| * @param key destintion path to an object within a storage backend. |
There was a problem hiding this comment.
Suggested change
| * @param key destintion path to an object within a storage backend. | |
| * @param key destination path to an object within a storage backend. |
| * @param size size of the object to upload | ||
| * @param key destination path to an object within a storage backend | ||
| */ | ||
| default long upload(Path path, int size, ObjectKey key) throws StorageBackendException { |
There was a problem hiding this comment.
Where is this upload call used ?
There was a problem hiding this comment.
It will be in a following PR (updated the PR description to make this clear), it touches RemoteStorageManager logic that is being refactored in other PRs (e.g. #531)
Backend SDKs may have optimized ways to upload directly from files, instead of loading to memory as part of the plugin.
jeqo
force-pushed
the
jeqo/upload-from-file
branch
from
40fc6ae
to
7b4c088
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backend SDKs may have optimized ways to upload directly from files, instead of loading to memory as part of the plugin.
This PR only covers the additional API, but the usage on RSM will be implemented in a following PR.