Add OS migration tests. #6792
Draft
Add OS migration tests. #6792
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
njohner
force-pushed
the
nj/CA-1266/os_migration
branch
4 times, most recently
from
3113176
to
57a6bbb
Compare
njohner
force-pushed
the
nj/CA-1266/os_migration
branch
6 times, most recently
from
96fb28b
to
80a4258
Compare
njohner
force-pushed
the
nj/CA-1266/os_migration
branch
from
5810cb7
to
bfabc72
Compare
njohner
force-pushed
the
nj/CA-1266/os_migration
branch
from
52d5367
to
fa8b78d
Compare
njohner
force-pushed
the
nj/CA-1266/os_migration
branch
2 times, most recently
from
b012833
to
e6a2aa4
Compare
njohner
force-pushed
the
nj/CA-1266/os_migration
branch
from
9aabdf9
to
c443c17
Compare
njohner
force-pushed
the
nj/CA-1266/os_migration
branch
2 times, most recently
from
006cbcb
to
0d2a6a9
Compare
added 10 commits
November 14, 2023 12:13
Access to fixture objects is done over a lookup table containing the object's path, so won't work anymore after an object is moved or it's title changed.
added 27 commits
November 14, 2023 12:13
We now also require that the migration excel is complete, i.e. all positions are in the excel.
If the default language is english, now that we have an title_en field, changing the title_de will not change the path anymore. So we need to make sure to run the tests with "de" as default language.
When moving data extraction to its own method, we also added a new logging entry. Dito when adding the new PositionsMapping.
We also take that chance to improve maintainability of the tests by extracting default values of the attributes in default_data. This avoids a lot of repetition of these values in the tests so that they don't have to be updated everywhere when attributes change.
njohner
force-pushed
the
nj/CA-1266/os_migration
branch
from
97b1a47
to
28b5f06
Compare
njohner
force-pushed
the
nj/CA-1266/os_migration
branch
from
a96872b
to
eacc040
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tests for 4teamwork/opengever.maintenance#240.
These will not get merged. I'd keep the branch around for future developments though.
I have just rebased (15.11.2023) and run the tests locally. Everything is green.