Improve OS migration script #251
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
February 18, 2021 10:54
lukasgraf
requested changes
Feb 22, 2021
| @@ -1013,6 +1013,7 @@ def create_repository_folders(self, items): | |||
| self.start_bundle_import(tmpdirname) | |||
|
|
|||
| shutil.rmtree(tmpdirname) | |||
| transaction.commit() | |||
There was a problem hiding this comment.
These should respect options.dryrun.
As we anyway do the migration on a copy of the deployment, we can take the risk of committing during the migration to speed it up.
njohner
force-pushed
the
nj/CA-1472/os_migration_permissions
branch
from
5767f0a
to
98c9501
Compare
|
All done. As discussed, the last commit will be tested in the next test-migration, see if it really speeds the migration up. |
This would access the blobs, which we do not have during the migration.
|
@lukasgraf can you have a look at the last commit? I had to exclude reindexing the SearchableText as we won't have the blobs during migration. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tests were also updated, see 4teamwork/opengever.core#6792
For https://4teamwork.atlassian.net/browse/CA-1472