Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] Clear alarm node refactor: async alarm searching, optimize alarm type pattern evaluation, throw error on unsuccessful alarm API response #10561

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

[WIP] Clear alarm node refactor: async alarm searching, optimize alarm type pattern evaluation, throw error on unsuccessful alarm API response #10561

wants to merge 5 commits into from

Commits on Apr 11, 2024

  1. Refactor create alarm node

    @dskarzh
    dskarzh committed Apr 11, 2024
    Configuration menu
    Copy the full SHA
    289d5e6 View commit details
    Browse the repository at this point in the history

Commits on Apr 12, 2024

  1. Use message originator as alarm originator when alarm data is taken f… 

    …rom a message
    @dskarzh
    dskarzh committed Apr 12, 2024
    Configuration menu
    Copy the full SHA
    456712b View commit details
    Browse the repository at this point in the history

  2. Clear alarm node tests: refactor existing tests and add new

    @dskarzh
    dskarzh committed Apr 12, 2024
    Configuration menu
    Copy the full SHA
    9b472d6 View commit details
    Browse the repository at this point in the history

  3. Clear alarm node: use DB executor to avoid blocking dispatcher thread… 

    … when searching for the alarm, throw error on unsuccessful API response, evaluate alarm type pattern only in originator type not ALARM branch
    @dskarzh
    dskarzh committed Apr 12, 2024
    Configuration menu
    Copy the full SHA
    b1f1dc0 View commit details
    Browse the repository at this point in the history

  4. Clear alarm node: use AlarmService.findByIdAsync() instead of DB exec… 

    …utor
    @dskarzh
    dskarzh committed Apr 12, 2024
    Configuration menu
    Copy the full SHA
    a109d37 View commit details
    Browse the repository at this point in the history