Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Clear alarm node refactor: async alarm searching, optimize alarm type pattern evaluation, throw error on unsuccessful alarm API response #10561

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

dskarzh
Copy link
Contributor

@dskarzh dskarzh commented Apr 12, 2024

Pull Request description

  • Alarm searching is now async, previously was blocking dispatcher thread
  • Alarm type pattern is evaluated only when it is actually needed in the originator type not ALARM branch, previously alarm type pattern was always evaluated
  • If alarm API call was unsuccessful, then throw error instead of tellSuccess(), currently alarm API returns unsuccessful result only when alarm was not found, which is very unlikely in the case of this rule node, because we fetch alarm right before clearing it.

PE PR

General checklist

  • You have reviewed the guidelines document.
  • Labels that classify your pull request have been added.
  • The milestone is specified and corresponds to fix version.
  • Description contains human-readable scope of changes.
  • No merge conflicts, commented blocks of code, code formatting issues.
  • Changes are backward compatible or upgrade script is provided.
  • Similar PR is opened for PE version to simplify merge. Crosslinks between PRs added. Required for internal contributors only.

Back-End feature checklist

  • Added corresponding unit and/or integration test(s). Provide written explanation in the PR description if you have failed to add tests.
  • If new dependency was added: the dependency tree is checked for conflicts.
  • If new service was added: the service is marked with corresponding @TbCoreComponent, @TbRuleEngineComponent, @TbTransportComponent, etc.
  • If new REST API was added: the RestClient.java was updated, issue for Python REST client is created.
  • If new yml property was added: make sure a description is added (above or near the property).

@ashvayka ashvayka added this to the 3.7.1 milestone May 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants