Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature: warehouse #23714
feature: warehouse #23714
Changes from 60 commits
b15f53a
23288e1
0464606
0fb889c
f85486f
7379eaa
8f3a35e
7210f1a
4d644c9
58f3439
f4fbf26
dc43b4f
456f03b
f404e00
c4f4058
320cde0
3e0d505
b9dea8c
968eac3
9d01097
48f48bb
eae72d8
66c0a4b
3a7885f
014e8a8
b2d51ab
0c804f5
162b0ad
6b4d5b0
e7ffcbe
1b80230
3e916ee
5d1772d
0b631e4
9a8740b
8c7dc42
1f587ee
8e7f708
e0a1a2e
8fa92ba
3428482
9aebca5
a6b0a5a
806571a
da76eac
e884e6a
d115bb8
11c19fd
c366417
beacd22
ab81838
9abbe0b
50f74b0
e5fc218
32a4306
b036e94
2268ca0
e9a442a
0af71f2
1dbb78c
1211586
3d04d07
c93a872
db120f9
d9e109d
3206a68
047bde5
ba0fac3
af878f4
52789ce
6cbfb0d
07a7d34
56d8ff1
91b64af
930bf65
0e8ae89
5613e51
99d6a79
8df58d6
4c9439a
021f2f9
dcf88de
bad0ada
abf5604
0dfa87b
6999423
52cd3de
aca85cb
f3f2ac1
407a7c7
ce050fd
dfc4f16
072a4b4
c57a241
db0f558
698fcd5
c3608e1
5fb6efe
74e649c
d9b9451
f74d3ad
e4c9565
a03ba5d
e42084d
570a0da
7fb881e
011a1af
a66e4f5
d0f2c8c
eb902ae
0ec8b9c
7046eb4
b558440
e2bfeed
707db58
655c7c0
66bc0d7
bad67cb
32f6d85
4322735
d79d6fd
e4561f2
187eddc
ee8c213
2d993ab
4d47d53
45c24a2
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
an aside: is this really the best ux? If we're asking users to check the console, might as well display the error message in a modal or textbox or something. I'd opt for a simple stringify of the error and chuck it in an alert wrapped with a
<pre>
so that people can copy-paste the error out to support.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this error handling shouldn't be here - it should be in createCollection itself, we won't need the try catch as well if we use mutate instead of mutateAsync
the toast.success should be in the onSuccess callback of the RQ mutation, and the error handling should be in the onError callback of the RQ mutation as well (all RQ mutations would have a default fallback error handler as well, so unless this component needs a specific error handling behaviour, we can leave it)
but yes - always surface the error message, don't let the user think 💪
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
these can be moved to its own types for clarity
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
agreed ^ either that or if they are coming directly from the API, use the types from the codegen