feature: warehouse #23714
Open
feature: warehouse #23714
+2,157
−400
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
jordienr
commented
May 3, 2024
jordienr
commented
- CRUD warehouse collections
- CRUD warehouse access tokens
- Navigate events in a collection
… into feat/event-collections
…tion.tsx, WarehouseCollectionDetail.tsx, and LogsLayout.tsx
…at/event-collections
joshenlim
reviewed
May 20, 2024
| onSuccess: (data: Awaited<ReturnType<typeof createCollection>>) => void | ||
| } | ||
|
|
||
| export function useCreateCollection({ projectRef, onSuccess }: CreateCollectionArgs) { |
There was a problem hiding this comment.
needs to be updated to be consistent with how we're doing RQ mutations
joshenlim
reviewed
May 20, 2024
| collectionToken: string | ||
| onSuccess: () => void | ||
| } | ||
| export function useDeleteCollection({ |
There was a problem hiding this comment.
needs to be updated to be consistent with how we're doing RQ mutations
joshenlim
reviewed
May 20, 2024
| name?: string | ||
| // description?: string | ||
| } | ||
| export function useUpdateCollection({ projectRef, collectionToken }: UpdateCollectionArgs) { |
There was a problem hiding this comment.
needs to be updated to be consistent with how we're doing RQ mutations
joshenlim
reviewed
May 20, 2024
| throw new Error('projectRef is required') | ||
| } | ||
|
|
||
| const response = await get<WarehouseEndpointsResponse>( |
joshenlim
reviewed
May 20, 2024
| throw new Error('projectRef is required') | ||
| } | ||
|
|
||
| const response = await get<WarehouseTenantResponse>( |
joshenlim
reviewed
May 20, 2024
|
|
||
| PageLayout.getLayout = (page) => <LogsLayout>{page}</LogsLayout> | ||
|
|
||
| export default observer(PageLayout) |
There was a problem hiding this comment.
no need for observer - observer is only for if we're using mobx (which we're deprecating)
joshenlim
reviewed
May 20, 2024
|
|
||
| PageLayout.getLayout = (page) => <LogsLayout>{page}</LogsLayout> | ||
|
|
||
| export default observer(PageLayout) |
….tsx Co-authored-by: Joshen Lim <joshenlimek@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.