Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New package: Inkdrop.Inkdrop.Portable version 5.8.1 #154151

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

CoolPlayLin
Copy link
Contributor

@CoolPlayLin CoolPlayLin commented May 18, 2024

Checklist for Pull Requests

Manifests

  • Have you checked that there aren't other open pull requests for the same manifest update/change?
  • This PR only modifies one (1) manifest
  • Have you validated your manifest locally with winget validate --manifest <path>?
  • Have you tested your manifest locally with winget install --manifest <path>?
  • Does your manifest conform to the 1.6 schema?

Note: <path> is the name of the directory containing the manifest you're submitting.


Microsoft Reviewers: Open in CodeFlow

@wingetbot
Copy link
Collaborator

Service Badge  Service Badge  

@wingetbot
Copy link
Collaborator

/AzurePipelines run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@wingetbot
Copy link
Collaborator

/AzurePipelines run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@Trenly
Copy link
Contributor

Trenly commented May 18, 2024

[Policy] Zip Binary

@microsoft-github-policy-service microsoft-github-policy-service bot added zip-binary Depends on library files that aren't available via symlink Blocking-Issue Manifest validation is blocked by a known issue. Needs-Author-Feedback This needs a response from the author. labels May 18, 2024
@CoolPlayLin
Copy link
Contributor Author

Why zip-binary Depends on library files that aren't available via symlink ?

@microsoft-github-policy-service microsoft-github-policy-service bot added Needs-Attention This work item needs to be reviewed by a member of the core team. and removed Needs-Author-Feedback This needs a response from the author. labels May 18, 2024
@Trenly
Copy link
Contributor

Trenly commented May 18, 2024

Why zip-binary Depends on library files that aren't available via symlink ?

image

@CoolPlayLin
Copy link
Contributor Author

But it can actually run normally

@Trenly
Copy link
Contributor

Trenly commented May 18, 2024

But it can actually run normally

Not in all cases. If the user has Developer mode enabled, or runs the install as admin, then attempting to run inkdrop using the command line alias that gets added causes the paths to the DLLs to be unavailable.

PS C:\Users\WDAGUtilityAccount\Desktop\winget-pkgs> Get-ARPTable

DisplayName    : Microsoft Edge
DisplayVersion : 126.0.2566.1
Publisher      : Microsoft Corporation
ProductCode    : Microsoft Edge
Scope          : Machine

DisplayName    : Microsoft Edge Update
DisplayVersion : 1.3.187.37
Publisher      :
ProductCode    : Microsoft Edge Update
Scope          : Machine

DisplayName    : Inkdrop
DisplayVersion : 5.8.1
Publisher      : Inkdrop
ProductCode    : Inkdrop.Inkdrop.Portable__DefaultSource
Scope          : User

PS C:\Users\WDAGUtilityAccount\Desktop\winget-pkgs> inkdrop
# Did not launch
PS C:\Users\WDAGUtilityAccount\Desktop\winget-pkgs> where.exe inkdrop
C:\Users\WDAGUtilityAccount\AppData\Local\Microsoft\WinGet\Links\inkdrop.exe
PS C:\Users\WDAGUtilityAccount\Desktop\winget-pkgs> inkdrop
# Did not launch
PS C:\Users\WDAGUtilityAccount\Desktop\winget-pkgs> Invoke-Expression inkdrop
# Did not launch
PS C:\Users\WDAGUtilityAccount\Desktop\winget-pkgs> $env:Path -match [Regex]::Escape('C:\Users\WDAGUtilityAccount\AppData\Local\Microsoft\WinGet\Links')
True

@wingetbot wingetbot added New-Package Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Validation-Domain labels May 18, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Author-Feedback This needs a response from the author. label May 18, 2024
@og-mrk
Copy link
Contributor

og-mrk commented May 18, 2024

But it can actually run normally

Not in all cases. If the user has Developer mode enabled, or runs the install as admin, then attempting to run inkdrop using the command line alias that gets added causes the paths to the DLLs to be unavailable.

Kind of curious on this particular situation, if the Command Alias won't work (that is, if the user installs the software as admin to make the Symbolic Link in the first place).. then couldn't we remove the PortableCommandAlias field entirely to partially resolve the zip-binary issue?

My apologies if the above suggestion/question might seem like a stupid idea, as I'm kind of new with this particular topic. Thanks in advance @Trenly 😄

@Trenly
Copy link
Contributor

Trenly commented May 18, 2024

But it can actually run normally

Not in all cases. If the user has Developer mode enabled, or runs the install as admin, then attempting to run inkdrop using the command line alias that gets added causes the paths to the DLLs to be unavailable.

Kind of curious on this particular situation, if the CommandAlias won't work (that is, if the user installs the software as admin to make the Symbolic Link in the first place).. then can't we just remove the PortableCommandAlias field and partially resolve the zip-binary issue?

My apologies if the above suggestion/question might seem like a stupid idea, as I'm kind of new with this particular topic. Thanks in advance @Trenly 😄

No, removing the command alias doesn’t change the underlying behavior. WinGet will always attempt to add the program to PATH - if PortableCommandAlias isn’t set, then WinGet will just use the file name as the alias. And, since WinGet doesn’t add start menu entries or desktop icons for portable apps, the only ways to start the application are to use the command line, or navigate to the executable directly. So an admin install always results in a symlink, and a user install results in a symlink if developer mode is enabled, and if there are dll dependencies then the application won’t launch properly from the command line if a symlink is used.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Blocking-Issue Manifest validation is blocked by a known issue. Needs-Attention This work item needs to be reviewed by a member of the core team. Needs-Author-Feedback This needs a response from the author. New-Package Validation-Domain zip-binary Depends on library files that aren't available via symlink
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants