Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New package: Inkdrop.Inkdrop version 5.8.1 #154144

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

CoolPlayLin
Copy link
Contributor

@CoolPlayLin CoolPlayLin commented May 18, 2024

Checklist for Pull Requests

Manifests

  • Have you checked that there aren't other open pull requests for the same manifest update/change?
  • This PR only modifies one (1) manifest
  • Have you validated your manifest locally with winget validate --manifest <path>?
  • Have you tested your manifest locally with winget install --manifest <path>?
  • Does your manifest conform to the 1.6 schema?

Note: <path> is the name of the directory containing the manifest you're submitting.


Microsoft Reviewers: Open in CodeFlow

@wingetbot
Copy link
Collaborator

Service Badge  Service Badge  

@wingetbot
Copy link
Collaborator

/AzurePipelines run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@CoolPlayLin
Copy link
Contributor Author

CoolPlayLin commented May 18, 2024

Hi @craftzdog
I've made this Pull Request to add inkdrop into windows package manager! Maybe this pull request needs the approval from you, its author

CC @stephengillie

@wingetbot wingetbot added New-Package Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Validation-Domain labels May 18, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Author-Feedback This needs a response from the author. label May 18, 2024
Copy link

@craftzdog craftzdog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @CoolPlayLin! I will approve it when PublisherUrl is updated

@wingetbot
Copy link
Collaborator

/AzurePipelines run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@microsoft-github-policy-service microsoft-github-policy-service bot removed Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Needs-Author-Feedback This needs a response from the author. Validation-Domain Changes-Requested Changes Requested New-Package labels May 18, 2024
@wingetbot
Copy link
Collaborator

/AzurePipelines run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@CoolPlayLin
Copy link
Contributor Author

CoolPlayLin commented May 18, 2024

@craftzdog I've applied your suggestion.
I've changed this installer into setup.exe. I shall put portable inkdrop into Inkdrop.Inkdrop.Portable

Copy link

@craftzdog craftzdog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@CoolPlayLin
Copy link
Contributor Author

@wingetbot wingetbot added Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Validation-Domain labels May 18, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Author-Feedback This needs a response from the author. label May 18, 2024
@CoolPlayLin
Copy link
Contributor Author

Validation-Domain should be dropped
image

@microsoft-github-policy-service microsoft-github-policy-service bot added Needs-Attention This work item needs to be reviewed by a member of the core team. and removed Needs-Author-Feedback This needs a response from the author. labels May 18, 2024
@craftzdog
Copy link

Configured the proper domain for the binary distribution: dist.inkdrop.app

@stephengillie
Copy link
Collaborator

Validation-Domain should be dropped image

Why should that label be dropped? The PackageUrl doesn't lead to the InstallerUrl. The image doesn't hold any data that would support this point - the existence of installer links doesn't guarantee that the PackageUrl will lead to them.

It appears that the developer hasn't released this version yet. It's possible that this might be a counterfeit upgrade, put out by another team to trick users into installing it.

@stephengillie stephengillie added the Blocking-Issue Manifest validation is blocked by a known issue. label May 20, 2024
@wingetbot
Copy link
Collaborator

/AzurePipelines run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@microsoft-github-policy-service microsoft-github-policy-service bot removed Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Blocking-Issue Manifest validation is blocked by a known issue. Needs-Attention This work item needs to be reviewed by a member of the core team. Validation-Domain Moderator-Approved One of the Moderators has reviewed and approved this PR New-Package labels May 25, 2024
@CoolPlayLin
Copy link
Contributor Author

Hi @stephengillie

Configured the proper domain for the binary distribution: dist.inkdrop.app

Issue has been resolved

@CoolPlayLin CoolPlayLin requested a review from Trenly May 25, 2024 03:24
@wingetbot wingetbot added New-Package Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Validation-Completed Validation passed labels May 25, 2024
@stephengillie
Copy link
Collaborator

I'm having difficulty getting this package to install correctly.

  • Normal install - ends with a setup error message, despite package manager reporting install complete. Shortcuts don't do anything.
  • Retry with VCRedist - ends in normal install. Clicking shortcuts gives "This shortcut target has been removed."

This might be a nested package, as one of the only EXEs it adds to the filesystem is Setup.exe, and after running this, Inkdrop appears to be installed.

@stephengillie stephengillie added the Needs-Author-Feedback This needs a response from the author. label May 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Needs-Author-Feedback This needs a response from the author. New-Package Validation-Completed Validation passed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants