-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New package: Inkdrop.Inkdrop version 5.8.1 #154144
base: master
Are you sure you want to change the base?
New package: Inkdrop.Inkdrop version 5.8.1 #154144
Conversation
/AzurePipelines run |
Azure Pipelines successfully started running 1 pipeline(s). |
Hi @craftzdog |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @CoolPlayLin! I will approve it when PublisherUrl
is updated
manifests/i/Inkdrop/Inkdrop/5.8.1/Inkdrop.Inkdrop.locale.en-US.yaml
Outdated
Show resolved
Hide resolved
/AzurePipelines run |
Azure Pipelines successfully started running 1 pipeline(s). |
/AzurePipelines run |
Azure Pipelines successfully started running 1 pipeline(s). |
@craftzdog I've applied your suggestion. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
Validation-Domain
should be dropped |
Configured the proper domain for the binary distribution: |
Why should that label be dropped? The It appears that the developer hasn't released this version yet. It's possible that this might be a counterfeit upgrade, put out by another team to trick users into installing it. |
/AzurePipelines run |
Azure Pipelines successfully started running 1 pipeline(s). |
Issue has been resolved |
I'm having difficulty getting this package to install correctly.
This might be a nested package, as one of the only |
Checklist for Pull Requests
Manifests
winget validate --manifest <path>
?winget install --manifest <path>
?Note:
<path>
is the name of the directory containing the manifest you're submitting.Microsoft Reviewers: Open in CodeFlow