feat: 1487 Chunk Manager Empty Iteration Failure

[JasonPaulGithub]

Description

A redesign is needed for the chunk_file process to match three types of file.

1. An empty file: write into the data_map the string EMPTY. On decrypt, we detect this and just create an empty file.
2. A small file: The whole content of those can be in the data_map. Just in SE lib we write the < MIN_SIZE to the data map.
3. A qualified file: Same as below (no change)

Fix for Issue : #1487

Manual testing needs to be done for this:

• Upload Empty File
• Download Empty File
• Upload Small File
• Download Small File
• Upload Qualified File
• Download Qualified File

[RolandSherwin]

So I assume this would get an address of 0000..?

[JasonPaulGithub]

I think so. Will this cause any issues?

[happybeing]

Probably too late for this PR but if you are working more in this area, is there a chance you can add the file path (not just name as it is now) to the ChunkManager uploaded files tracking? More in this issue #1576

I want to use the ChunkManager and to be able to access the xor address and full path of each uploaded file, not just the filenames.

[JasonPaulGithub]

Hi @happybeing,
I think this is possible. @RolandSherwin What do you think?
Cheers 👍

[joshuef]

the SmallFile here is not encrypted, so we're actually potentially exposing user data here.

This is one reason we've opted to error out on small files for now until they can be reliably encrypted via the Folders commands. (though that's unintentionally leaking out via the error handling in the client here.

So I think the solution here for #1487 is to handle the error, as opposed to attempting to chunk the file (but potentially not encrypting the data within).

---

If we accept that the storing of the file can throw an error for now, we can make a follow up issue to track encryption of small files via the Folders command apis.

How does that sound?