Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chunk manager should not error out if one file fails #1487

Open
RolandSherwin opened this issue Mar 22, 2024 · 1 comment
Open

Chunk manager should not error out if one file fails #1487

RolandSherwin opened this issue Mar 22, 2024 · 1 comment
Labels

Comments

@RolandSherwin
Copy link
Member

RolandSherwin commented Mar 22, 2024

Track the failures to be retried / logged.
The uploader can fail if the manager sends in 0 chunks.
https://safenetforum.org/t/bbbbbadnet-21-03-2024-testnet/39458/156

Related PR: #1528
Related Slack Conversation: https://maidsafe.slack.com/archives/C050EDL5ACS/p1711548766280269

Note: We will need CI level tests for the changes required to solve this issue.

@JasonPaulGithub
Copy link
Contributor

JasonPaulGithub commented Mar 27, 2024

we'll get a pattern match on file_size inside of sn_client/src/files.rs and apply the solutions mentioned here to the following outcomes;

  1. empty file
  2. file under threshold
  3. file over threshold

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants