Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clean-up error handler & fix message for unknown API errors #22379
base: main
Are you sure you want to change the base?
Clean-up error handler & fix message for unknown API errors #22379
Changes from 6 commits
541f5d0
a0ef696
8df1a9f
4aac062
236c6a9
21c19cd
c6950c6
0e5a045
f2d8038
e80671c
d07bed1
d76629c
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Check warning on line 1 in .changeset/flat-bottles-unite.md
GitHub Actions / Lint
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lets add a comment here to make it very clear that this
Promise.resolve
is here to support both regular and async functions asfn()
. I personally think thats not directly clear from just the code/types and may be a footgun for future refactoring.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah good thought! The function has initially been adapted from
directus/api/src/utils/async-handler.ts
Lines 3 to 4 in 7e6980d
Promise.resolve
wrapping.