Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean-up error handler & fix message for unknown API errors #22379

Open
wants to merge 12 commits into
base: main
Choose a base branch
from
Open

Clean-up error handler & fix message for unknown API errors #22379

wants to merge 12 commits into from
+328 −65

Commits on May 3, 2024

  1. Fix message for unknown errors & additional clean-ups

    @paescuj
    paescuj committed May 3, 2024
    Configuration menu
    Copy the full SHA
    541f5d0 View commit details
    Browse the repository at this point in the history

  2. Add changeset

    @paescuj
    paescuj committed May 3, 2024
    Configuration menu
    Copy the full SHA
    a0ef696 View commit details
    Browse the repository at this point in the history

  3. Slightly more readable stack check 

    Co-authored-by: Hannes Küttner <4376726+hanneskuettner@users.noreply.github.com>
    @paescuj @hanneskuettner
    paescuj and hanneskuettner committed May 3, 2024
    Configuration menu
    Copy the full SHA
    8df1a9f View commit details
    Browse the repository at this point in the history

  4. Add missing semicolon

    @hanneskuettner
    hanneskuettner committed May 3, 2024
    Configuration menu
    Copy the full SHA
    4aac062 View commit details
    Browse the repository at this point in the history

  5. Remove junk file

    @hanneskuettner
    hanneskuettner committed May 3, 2024
    Configuration menu
    Copy the full SHA
    236c6a9 View commit details
    Browse the repository at this point in the history

  6. Only use stack traces from actual Errors

    @paescuj
    paescuj committed May 3, 2024
    Configuration menu
    Copy the full SHA
    21c19cd View commit details
    Browse the repository at this point in the history

  7. Add InternalServerError, use in error handler

    @paescuj
    paescuj committed May 3, 2024
    Configuration menu
    Copy the full SHA
    c6950c6 View commit details
    Browse the repository at this point in the history

Commits on May 13, 2024

  1. Merge branch 'main' into enhance-api-error-handler

    @hanneskuettner
    hanneskuettner committed May 13, 2024
    Configuration menu
    Copy the full SHA
    0e5a045 View commit details
    Browse the repository at this point in the history

Commits on May 29, 2024

  1. Ensure error.code cannot be overwritten 

    Co-authored-by: Brainslug <tim@brainslug.nl>
    @paescuj @br41nslug
    paescuj and br41nslug committed May 29, 2024
    Configuration menu
    Copy the full SHA
    f2d8038 View commit details
    Browse the repository at this point in the history

Commits on May 31, 2024

  1. Catch case where headers have already been sent

    @paescuj
    paescuj committed May 31, 2024
    Configuration menu
    Copy the full SHA
    e80671c View commit details
    Browse the repository at this point in the history

  2. Enhance asyncErrorHandler signature & handler call 

    - Omit Promise.resolve as we know we receive a promise in this case
- Use args from ErrorRequestHandler
    @paescuj
    paescuj committed May 31, 2024
    Configuration menu
    Copy the full SHA
    d07bed1 View commit details
    Browse the repository at this point in the history

  3. Add tests

    @paescuj
    paescuj committed May 31, 2024
    Configuration menu
    Copy the full SHA
    d76629c View commit details
    Browse the repository at this point in the history