make the Benefits page readable: add Converters TOC #369
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
upgrading us from a very unfriendly scroll journey
✅ Deploy Preview for astounding-beignet-8ca2d6 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
hopefully this fixes the markdown
christinerogers
changed the title
christinerogers
changed the title
sappelhoff
reviewed
Mar 14, 2024
There was a problem hiding this comment.
+1 for the TOC, but let's use the headings that are automatically generated -- with the current changes (without my suggestions), we'd have duplicates, see: https://deploy-preview-369--astounding-beignet-8ca2d6.netlify.app/benefits#data-converters
Comment on lines
+15
to
+20
| Tools which convert data to/from BIDS : | ||
| * [Data converters](#data-converters) | ||
| * [MEEG converters](#meeg-converters) | ||
| * [from BIDS converters](#from-bids-converters) | ||
| * [Physio converters](#physio-converters) | ||
| * [Other converters](#other-converters) |
There was a problem hiding this comment.
Suggested change
| Tools which convert data to/from BIDS : | |
| * [Data converters](#data-converters) | |
| * [MEEG converters](#meeg-converters) | |
| * [from BIDS converters](#from-bids-converters) | |
| * [Physio converters](#physio-converters) | |
| * [Other converters](#other-converters) | |
| Software tools to convert data to or from BIDS: | |
| - [MRI and PET converters](#mri-and-pet-converters) | |
| - [EEG, MEG, iEEG converters](#eeg-meg-ieeg-converters) | |
| - ['From BIDS' converters](#from-bids-converters) | |
| - [Physiological data converters](#physiological-data-converters) | |
| - [Miscellaneous](#miscellaneous) |
Comment on lines
+22
to
42
| ### Data converters | ||
|
|
||
| {% include converters_table.html members=site.data.converters %} | ||
|
|
||
| ### MEEG converters | ||
|
|
||
| {% include converters_table.html members=site.data.MEEG_converters %} | ||
|
|
||
| ### from BIDS converters | ||
|
|
||
| {% include converters_table.html members=site.data.from_BIDS_converters %} | ||
|
|
||
| ### Physio converters | ||
|
|
||
| {% include converters_table.html members=site.data.physio_converters %} | ||
|
|
||
| ### Other converters | ||
|
|
||
| {% include converters_table.html members=site.data.other_converters %} | ||
|
|
||
| # Software currently supporting BIDS: |
There was a problem hiding this comment.
Suggested change
| ### Data converters | |
| {% include converters_table.html members=site.data.converters %} | |
| ### MEEG converters | |
| {% include converters_table.html members=site.data.MEEG_converters %} | |
| ### from BIDS converters | |
| {% include converters_table.html members=site.data.from_BIDS_converters %} | |
| ### Physio converters | |
| {% include converters_table.html members=site.data.physio_converters %} | |
| ### Other converters | |
| {% include converters_table.html members=site.data.other_converters %} | |
| # Software currently supporting BIDS: | |
| {% include converters_table.html members=site.data.converters %} | |
| {% include converters_table.html members=site.data.MEEG_converters %} | |
| {% include converters_table.html members=site.data.from_BIDS_converters %} | |
| {% include converters_table.html members=site.data.physio_converters %} | |
| {% include converters_table.html members=site.data.other_converters %} | |
| # Software currently supporting BIDS: |
|
probably worth revisiting this PR to see if what's main looks "good enough" https://bids-website.readthedocs.io/en/latest/tools/converters/ |
|
I think we've lost something with the subpages here. -- the ability to search the page for (e.g.) "EEG" since a lot of tools are under one category but could be under multiple. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To upgrade the Benefits page from an unfriendly scroll journey --
This PR adds internal links in the Converters section and a mini-TOC for them