Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DRAFT] Updated DDL cdn deployment and endpoint for shorter cache control #2305

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

[DRAFT] Updated DDL cdn deployment and endpoint for shorter cache control #2305

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
bcd4972
Updated cdn deployment and endpoint for shorter cache control
jadahiya-MSFT May 3, 2024
ad15adc
Added comment about the 7dttl
jadahiya-MSFT May 3, 2024
04312fb
Fixed typo
jadahiya-MSFT May 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
8 changes: 8 additions & 0 deletions tools/yaml-templates/build-test-publish.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,6 +106,14 @@ steps:
flattenFolders: true
displayName: 'Copy validDomains for CDN'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we want it to be 7 days, should we remove this line which will still put a copy in the original 7300 days place?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We want this for back compat with the older versions of TeamsJS, to make sure that they are still being supported. The 7300 days does do a refresh from origin every 7 days I believe and so it will eventually be propagated.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh yes, makes sense. Can you add a comment above this line explaining that? Would not be crazy for a dummy like me to come along later and be like "Why do we have two of these things? DELETE"


- task: CopyFiles@2
TrevorJoelHarris marked this conversation as resolved.
Show resolved Hide resolved
inputs:
Contents: |
packages\teams-js\src\artifactsForCDN\validDomains.json
TargetFolder: '$(Build.ArtifactStagingDirectory)\7dttl\validDomains\json'
flattenFolders: true
displayName: 'Copy validDomains for CDN with 7 day cache control'

- task: CopyFiles@2
inputs:
Contents: |
Expand Down