[DRAFT] Updated DDL cdn deployment and endpoint for shorter cache control #2305
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TrevorJoelHarris
previously approved these changes
May 3, 2024
AE-MS
reviewed
May 3, 2024
AE-MS
reviewed
May 3, 2024
| @@ -106,6 +106,15 @@ steps: | |||
| flattenFolders: true | |||
| displayName: 'Copy validDomains for CDN' | |||
There was a problem hiding this comment.
If we want it to be 7 days, should we remove this line which will still put a copy in the original 7300 days place?
There was a problem hiding this comment.
We want this for back compat with the older versions of TeamsJS, to make sure that they are still being supported. The 7300 days does do a refresh from origin every 7 days I believe and so it will eventually be propagated.
There was a problem hiding this comment.
Oh yes, makes sense. Can you add a comment above this line explaining that? Would not be crazy for a dummy like me to come along later and be like "Why do we have two of these things? DELETE"
jadahiya-MSFT
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently our DDL deployments have a default
cache-controlsetting of 7 days to 7300 days. This means that when we make updates to the DDL that need to be seen more immediately we would need to flush the CDN. Moving thevalidDomainsartifact into a*7dttl*folder designation updates thecache-controlto one with a 7 day time to live to avoid needing a CDN flush.