Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improves window component loads #1699

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Improves window component loads #1699

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
16 changes: 6 additions & 10 deletions HPXMLtoOpenStudio/measure.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2312,9 +2312,8 @@ def add_component_loads_output(model, hpxml_osm_map, loads_data)
fail "Unexpected subsurface for component loads: '#{ss.name}'." if key.nil?

if (surface_type == 'Window') || (surface_type == 'Skylight')
vars = { 'Surface Inside Face Convection Heat Gain Energy' => 'ss_conv',
'Surface Inside Face Internal Gains Radiation Heat Gain Energy' => 'ss_ig',
'Surface Inside Face Net Surface Thermal Radiation Heat Gain Energy' => 'ss_surf' }
vars = { 'Surface Window Inside Face Glazing Zone Convection Heat Gain Rate' => 'ss_glaz',
'Surface Window Inside Face Glazing Net Infrared Heat Transfer Rate' => 'ss_infra' }
else
vars = { 'Surface Inside Face Solar Radiation Heat Gain Energy' => 'ss_sol',
'Surface Inside Face Lights Radiation Heat Gain Energy' => 'ss_lgt',
Expand All @@ -2336,10 +2335,8 @@ def add_component_loads_output(model, hpxml_osm_map, loads_data)

key = { 'Window' => :windows_solar,
'Skylight' => :skylights_solar }[surface_type]
vars = { 'Surface Window Transmitted Solar Radiation Energy' => 'ss_trans_in',
vars = { 'Surface Window Transmitted Solar Radiation Rate' => 'ss_trans_in',
'Surface Window Shortwave from Zone Back Out Window Heat Transfer Rate' => 'ss_back_out',
'Surface Window Total Glazing Layers Absorbed Shortwave Radiation Rate' => 'ss_sw_abs',
'Surface Window Total Glazing Layers Absorbed Solar Radiation Energy' => 'ss_sol_abs',
'Surface Inside Face Initial Transmitted Diffuse Transmitted Out Window Solar Radiation Rate' => 'ss_trans_out' }

surfaces_sensors[key] << []
Expand Down Expand Up @@ -2562,10 +2559,9 @@ def add_component_loads_output(model, hpxml_osm_map, loads_data)
surface_sensors.each do |sensors|
s = "Set hr_#{k} = hr_#{k}"
sensors.each do |sensor|
# remove ss_net if switch
if sensor.name.to_s.start_with?('ss_net', 'ss_sol_abs', 'ss_trans_in')
s += " - #{sensor.name}"
elsif sensor.name.to_s.start_with?('ss_sw_abs', 'ss_trans_out', 'ss_back_out')
if sensor.name.to_s.start_with?('ss_trans_in', 'ss_infra', 'ss_glaz')
s += " - #{sensor.name} * ZoneTimestep * 3600"
elsif sensor.name.to_s.start_with?('ss_trans_out', 'ss_back_out')
s += " + #{sensor.name} * ZoneTimestep * 3600"
else
s += " + #{sensor.name}"
Expand Down