Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improves window component loads #1699

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Conversation

shorowit
Copy link
Contributor

Pull Request Description

Improves window component load calculation, uses EnergyPlus improvements in NREL/EnergyPlus#10444. This will need to wait for the E+ 24.2 release.

Checklist

PR Author: Check these when they're done. Not all may apply. strikethrough and check any that do not apply.

PR Reviewer: Verify each has been completed.

  • Schematron validator (EPvalidator.xml) has been updated
  • Sample files have been added/updated (openstudio tasks.rb update_hpxmls)
  • Tests have been added/updated (e.g., HPXMLtoOpenStudio/tests/test*.rb and/or workflow/tests/test*.rb)
  • Documentation has been updated
  • Changelog has been updated
  • openstudio tasks.rb update_measures has been run
  • No unexpected changes to simulation results of sample files

@shorowit shorowit added this to the 1.9.0 milestone Apr 29, 2024
@shorowit shorowit self-assigned this Apr 29, 2024
Base automatically changed from os380 to master May 7, 2024 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Work on hold/Waiting on others
Development

Successfully merging this pull request may close these issues.

None yet

1 participant